From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] MIPS: cavium-octeon: cvmx-helper-board: print unknown board warning only once
Date: Mon, 27 May 2013 14:19:03 +0400 [thread overview]
Message-ID: <51A33317.2060202@cogentembedded.com> (raw)
In-Reply-To: <1369600543-21558-1-git-send-email-aaro.koskinen@iki.fi>
Hello.
On 27-05-2013 0:35, Aaro Koskinen wrote:
> When booting a new board for the first time, the console is flooded with
> "Unknown board" messages. This is not really helpful. Board type is not
> going to change after the boot, so it's sufficient to print the warning
> only once.
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> ---
> arch/mips/cavium-octeon/executive/cvmx-helper-board.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
> diff --git a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
> index 7c64977..e0451a0 100644
> --- a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
> +++ b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
[...]
> @@ -184,8 +186,7 @@ int cvmx_helper_board_get_mii_address(int ipd_port)
> }
>
> /* Some unknown board. Somebody forgot to update this function... */
> - cvmx_dprintf
> - ("cvmx_helper_board_get_mii_address: Unknown board type %d\n",
> + pr_warn_once("%s: Unknown board type %d\n", __func__,
> cvmx_sysinfo_get()->board_type);
Please align this line under the next char under (.
WVR, Sergei
next prev parent reply other threads:[~2013-05-27 10:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-26 20:35 [PATCH 1/2] MIPS: cavium-octeon: cvmx-helper-board: print unknown board warning only once Aaro Koskinen
2013-05-26 20:35 ` [PATCH 2/2] MIPS: cavium-octeon: enable interfaces on EdgeRouter Lite Aaro Koskinen
2013-05-27 10:19 ` Sergei Shtylyov [this message]
2013-05-27 17:17 ` [PATCH 1/2] MIPS: cavium-octeon: cvmx-helper-board: print unknown board warning only once Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A33317.2060202@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=aaro.koskinen@iki.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox