From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756156Ab3E0RxO (ORCPT ); Mon, 27 May 2013 13:53:14 -0400 Received: from mail-lb0-f173.google.com ([209.85.217.173]:43340 "EHLO mail-lb0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755771Ab3E0RxN (ORCPT ); Mon, 27 May 2013 13:53:13 -0400 Message-ID: <51A39D84.4090505@cogentembedded.com> Date: Mon, 27 May 2013 21:53:08 +0400 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: atomlin@redhat.com CC: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com, pshelar@nicira.com, mst@redhat.com, alexander.h.duyck@intel.com, linux-kernel@vger.kernel.org Subject: Re: [Patch v1] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets References: <1369574241-21397-1-git-send-email-atomlin@redhat.com> <51A23825.7000303@cogentembedded.com> In-Reply-To: <51A23825.7000303@cogentembedded.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 26-05-2013 20:28, Sergei Shtylyov wrote: >> From: Aaron Tomlin >> Failed GFP_ATOMIC allocations by the network stack result in dropped >> packets, which will be received on a subsequent retransmit, and an >> unnecessary, noisy warning with a kernel backtrace. >> These warnings are harmless, but they still cause users to panic and >> file bug reports over dropped packets. It would be better to hide the >> failed allocation warnings and backtraces, and let retransmits handle >> dropped packets quietly. >> Signed-off-by: Aaron Tomlin >> --- >> net/core/skbuff.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> diff --git a/net/core/skbuff.c b/net/core/skbuff.c >> index af9185d..02139d6 100644 >> --- a/net/core/skbuff.c >> +++ b/net/core/skbuff.c >> @@ -236,7 +236,7 @@ struct sk_buff *__alloc_skb(unsigned int size, >> gfp_t gfp_mask, >> ? skbuff_fclone_cache : skbuff_head_cache; >> >> if (sk_memalloc_socks() && (flags & SKB_ALLOC_RX)) >> - gfp_mask |= __GFP_MEMALLOC; >> + gfp_mask |= (__GFP_MEMALLOC|__GFP_NOWARN); > Parens not needed here. And add spaces around | please, to be consistent with other code. WBR, Sergei