* [PATCH] firmware: move EXPORT_SYMBOL annotations
@ 2013-05-23 20:17 Daniel Mack
2013-05-27 8:35 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Mack @ 2013-05-23 20:17 UTC (permalink / raw)
To: linux-kernel; +Cc: ming.lei, gregkh, tiwai, Daniel Mack
Move EXPORT_SYMBOL annotations so they follow immediately after the
closing function brace line.
Signed-off-by: Daniel Mack <zonque@gmail.com>
---
drivers/base/firmware_class.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
index 4b1f926..4d9643f 100644
--- a/drivers/base/firmware_class.c
+++ b/drivers/base/firmware_class.c
@@ -1079,6 +1079,7 @@ request_firmware(const struct firmware **firmware_p, const char *name,
{
return _request_firmware(firmware_p, name, device, true, false);
}
+EXPORT_SYMBOL(request_firmware);
/**
* release_firmware: - release the resource associated with a firmware image
@@ -1092,6 +1093,7 @@ void release_firmware(const struct firmware *fw)
kfree(fw);
}
}
+EXPORT_SYMBOL(release_firmware);
/* Async support */
struct firmware_work {
@@ -1172,6 +1174,7 @@ request_firmware_nowait(
schedule_work(&fw_work->work);
return 0;
}
+EXPORT_SYMBOL(request_firmware_nowait);
/**
* cache_firmware - cache one firmware image in kernel memory space
@@ -1202,6 +1205,7 @@ int cache_firmware(const char *fw_name)
return ret;
}
+EXPORT_SYMBOL_GPL(cache_firmware);
/**
* uncache_firmware - remove one cached firmware image
@@ -1232,6 +1236,7 @@ int uncache_firmware(const char *fw_name)
return -EINVAL;
}
+EXPORT_SYMBOL_GPL(uncache_firmware);
#ifdef CONFIG_PM_SLEEP
static ASYNC_DOMAIN_EXCLUSIVE(fw_cache_domain);
@@ -1536,9 +1541,3 @@ static void __exit firmware_class_exit(void)
fs_initcall(firmware_class_init);
module_exit(firmware_class_exit);
-
-EXPORT_SYMBOL(release_firmware);
-EXPORT_SYMBOL(request_firmware);
-EXPORT_SYMBOL(request_firmware_nowait);
-EXPORT_SYMBOL_GPL(cache_firmware);
-EXPORT_SYMBOL_GPL(uncache_firmware);
--
1.8.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] firmware: move EXPORT_SYMBOL annotations
2013-05-23 20:17 [PATCH] firmware: move EXPORT_SYMBOL annotations Daniel Mack
@ 2013-05-27 8:35 ` Takashi Iwai
2013-05-28 18:30 ` Daniel Mack
0 siblings, 1 reply; 4+ messages in thread
From: Takashi Iwai @ 2013-05-27 8:35 UTC (permalink / raw)
To: Daniel Mack; +Cc: linux-kernel, ming.lei, gregkh, tiwai
At Thu, 23 May 2013 22:17:18 +0200,
Daniel Mack wrote:
>
> Move EXPORT_SYMBOL annotations so they follow immediately after the
> closing function brace line.
>
> Signed-off-by: Daniel Mack <zonque@gmail.com>
Acked-by: Takashi Iwai <tiwai@suse.de>
thanks,
Takashi
> ---
> drivers/base/firmware_class.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
> index 4b1f926..4d9643f 100644
> --- a/drivers/base/firmware_class.c
> +++ b/drivers/base/firmware_class.c
> @@ -1079,6 +1079,7 @@ request_firmware(const struct firmware **firmware_p, const char *name,
> {
> return _request_firmware(firmware_p, name, device, true, false);
> }
> +EXPORT_SYMBOL(request_firmware);
>
> /**
> * release_firmware: - release the resource associated with a firmware image
> @@ -1092,6 +1093,7 @@ void release_firmware(const struct firmware *fw)
> kfree(fw);
> }
> }
> +EXPORT_SYMBOL(release_firmware);
>
> /* Async support */
> struct firmware_work {
> @@ -1172,6 +1174,7 @@ request_firmware_nowait(
> schedule_work(&fw_work->work);
> return 0;
> }
> +EXPORT_SYMBOL(request_firmware_nowait);
>
> /**
> * cache_firmware - cache one firmware image in kernel memory space
> @@ -1202,6 +1205,7 @@ int cache_firmware(const char *fw_name)
>
> return ret;
> }
> +EXPORT_SYMBOL_GPL(cache_firmware);
>
> /**
> * uncache_firmware - remove one cached firmware image
> @@ -1232,6 +1236,7 @@ int uncache_firmware(const char *fw_name)
>
> return -EINVAL;
> }
> +EXPORT_SYMBOL_GPL(uncache_firmware);
>
> #ifdef CONFIG_PM_SLEEP
> static ASYNC_DOMAIN_EXCLUSIVE(fw_cache_domain);
> @@ -1536,9 +1541,3 @@ static void __exit firmware_class_exit(void)
>
> fs_initcall(firmware_class_init);
> module_exit(firmware_class_exit);
> -
> -EXPORT_SYMBOL(release_firmware);
> -EXPORT_SYMBOL(request_firmware);
> -EXPORT_SYMBOL(request_firmware_nowait);
> -EXPORT_SYMBOL_GPL(cache_firmware);
> -EXPORT_SYMBOL_GPL(uncache_firmware);
> --
> 1.8.1.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] firmware: move EXPORT_SYMBOL annotations
2013-05-27 8:35 ` Takashi Iwai
@ 2013-05-28 18:30 ` Daniel Mack
2013-05-28 19:27 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Mack @ 2013-05-28 18:30 UTC (permalink / raw)
To: Takashi Iwai, gregkh; +Cc: linux-kernel, ming.lei
On 27.05.2013 10:35, Takashi Iwai wrote:
> At Thu, 23 May 2013 22:17:18 +0200,
> Daniel Mack wrote:
>>
>> Move EXPORT_SYMBOL annotations so they follow immediately after the
>> closing function brace line.
>>
>> Signed-off-by: Daniel Mack <zonque@gmail.com>
>
> Acked-by: Takashi Iwai <tiwai@suse.de>
Thanks. Greg, could you take this through your tree?
Daniel
>
>
> thanks,
>
> Takashi
>
>> ---
>> drivers/base/firmware_class.c | 11 +++++------
>> 1 file changed, 5 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
>> index 4b1f926..4d9643f 100644
>> --- a/drivers/base/firmware_class.c
>> +++ b/drivers/base/firmware_class.c
>> @@ -1079,6 +1079,7 @@ request_firmware(const struct firmware **firmware_p, const char *name,
>> {
>> return _request_firmware(firmware_p, name, device, true, false);
>> }
>> +EXPORT_SYMBOL(request_firmware);
>>
>> /**
>> * release_firmware: - release the resource associated with a firmware image
>> @@ -1092,6 +1093,7 @@ void release_firmware(const struct firmware *fw)
>> kfree(fw);
>> }
>> }
>> +EXPORT_SYMBOL(release_firmware);
>>
>> /* Async support */
>> struct firmware_work {
>> @@ -1172,6 +1174,7 @@ request_firmware_nowait(
>> schedule_work(&fw_work->work);
>> return 0;
>> }
>> +EXPORT_SYMBOL(request_firmware_nowait);
>>
>> /**
>> * cache_firmware - cache one firmware image in kernel memory space
>> @@ -1202,6 +1205,7 @@ int cache_firmware(const char *fw_name)
>>
>> return ret;
>> }
>> +EXPORT_SYMBOL_GPL(cache_firmware);
>>
>> /**
>> * uncache_firmware - remove one cached firmware image
>> @@ -1232,6 +1236,7 @@ int uncache_firmware(const char *fw_name)
>>
>> return -EINVAL;
>> }
>> +EXPORT_SYMBOL_GPL(uncache_firmware);
>>
>> #ifdef CONFIG_PM_SLEEP
>> static ASYNC_DOMAIN_EXCLUSIVE(fw_cache_domain);
>> @@ -1536,9 +1541,3 @@ static void __exit firmware_class_exit(void)
>>
>> fs_initcall(firmware_class_init);
>> module_exit(firmware_class_exit);
>> -
>> -EXPORT_SYMBOL(release_firmware);
>> -EXPORT_SYMBOL(request_firmware);
>> -EXPORT_SYMBOL(request_firmware_nowait);
>> -EXPORT_SYMBOL_GPL(cache_firmware);
>> -EXPORT_SYMBOL_GPL(uncache_firmware);
>> --
>> 1.8.1.4
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] firmware: move EXPORT_SYMBOL annotations
2013-05-28 18:30 ` Daniel Mack
@ 2013-05-28 19:27 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2013-05-28 19:27 UTC (permalink / raw)
To: Daniel Mack; +Cc: Takashi Iwai, linux-kernel, ming.lei
On Tue, May 28, 2013 at 08:30:45PM +0200, Daniel Mack wrote:
> On 27.05.2013 10:35, Takashi Iwai wrote:
> > At Thu, 23 May 2013 22:17:18 +0200,
> > Daniel Mack wrote:
> >>
> >> Move EXPORT_SYMBOL annotations so they follow immediately after the
> >> closing function brace line.
> >>
> >> Signed-off-by: Daniel Mack <zonque@gmail.com>
> >
> > Acked-by: Takashi Iwai <tiwai@suse.de>
>
> Thanks. Greg, could you take this through your tree?
Yes, will do, give me some time to catch up on patches after returning
from LinuxCon Japan this week.
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-05-28 19:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-23 20:17 [PATCH] firmware: move EXPORT_SYMBOL annotations Daniel Mack
2013-05-27 8:35 ` Takashi Iwai
2013-05-28 18:30 ` Daniel Mack
2013-05-28 19:27 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox