* [PATCH] mtd: fix kfree bcm47xxsflash
@ 2013-05-05 8:40 chenlibo.3
2013-05-22 3:51 ` [PATCH RESEND] " Libo Chen
0 siblings, 1 reply; 7+ messages in thread
From: chenlibo.3 @ 2013-05-05 8:40 UTC (permalink / raw)
To: dwmw2; +Cc: linux-mtd, linux-kernel, lizefan, Libo Chen
From: Libo Chen <libo.chen@huawei.com>
mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its member.
Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
drivers/mtd/devices/bcm47xxsflash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/devices/bcm47xxsflash.c b/drivers/mtd/devices/bcm47xxsflash.c
index 9526628..4aa9141 100644
--- a/drivers/mtd/devices/bcm47xxsflash.c
+++ b/drivers/mtd/devices/bcm47xxsflash.c
@@ -76,7 +76,7 @@ static int bcm47xxsflash_bcma_probe(struct platform_device *pdev)
return 0;
err_dev_reg:
- kfree(&b47s->mtd);
+ kfree(b47s);
out:
return err;
}
--
1.8.1.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH RESEND] mtd: fix kfree bcm47xxsflash
2013-05-05 8:40 [PATCH] mtd: fix kfree bcm47xxsflash chenlibo.3
@ 2013-05-22 3:51 ` Libo Chen
2013-05-22 5:32 ` Rafał Miłecki
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Libo Chen @ 2013-05-22 3:51 UTC (permalink / raw)
To: dwmw2
Cc: zajec5, artem.bityutskiy, wfp5p, hauke, linux-mtd, LKML,
Andrew Morton, Li Zefan
mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its member.
Signed-off-by: Libo Chen <libo.chen@huawei.com>
Acked-by: Rafał Miłecki <zajec5@gmail.com>
---
drivers/mtd/devices/bcm47xxsflash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
* add Acked-by: Rafał Miłecki <zajec5@gmail.com>
* change send list
diff --git a/drivers/mtd/devices/bcm47xxsflash.c b/drivers/mtd/devices/bcm47xxsflash.c
index 9526628..4aa9141 100644
--- a/drivers/mtd/devices/bcm47xxsflash.c
+++ b/drivers/mtd/devices/bcm47xxsflash.c
@@ -76,7 +76,7 @@ static int bcm47xxsflash_bcma_probe(struct platform_device *pdev)
return 0;
err_dev_reg:
- kfree(&b47s->mtd);
+ kfree(b47s);
out:
return err;
}
--
1.8.1.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH RESEND] mtd: fix kfree bcm47xxsflash
2013-05-22 3:51 ` [PATCH RESEND] " Libo Chen
@ 2013-05-22 5:32 ` Rafał Miłecki
2013-05-28 12:40 ` Libo Chen
2013-05-28 15:29 ` Andy Shevchenko
2 siblings, 0 replies; 7+ messages in thread
From: Rafał Miłecki @ 2013-05-22 5:32 UTC (permalink / raw)
To: Libo Chen
Cc: dwmw2, artem.bityutskiy, wfp5p, hauke, linux-mtd, LKML,
Andrew Morton, Li Zefan
2013/5/22 Libo Chen <clbchenlibo.chen@huawei.com>:
> mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its member.
Thanks!
--
Rafał
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH RESEND] mtd: fix kfree bcm47xxsflash
2013-05-22 3:51 ` [PATCH RESEND] " Libo Chen
2013-05-22 5:32 ` Rafał Miłecki
@ 2013-05-28 12:40 ` Libo Chen
2013-05-28 12:49 ` Rafał Miłecki
2013-05-28 15:29 ` Andy Shevchenko
2 siblings, 1 reply; 7+ messages in thread
From: Libo Chen @ 2013-05-28 12:40 UTC (permalink / raw)
To: dwmw2
Cc: zajec5, artem.bityutskiy, wfp5p, hauke, linux-mtd, LKML,
Andrew Morton, Li Zefan, Greg KH
ping...
On 2013/5/22 11:51, Libo Chen wrote:
>
> mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its member.
>
> Signed-off-by: Libo Chen <libo.chen@huawei.com>
> Acked-by: Rafał Miłecki <zajec5@gmail.com>
> ---
> drivers/mtd/devices/bcm47xxsflash.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> * add Acked-by: Rafał Miłecki <zajec5@gmail.com>
> * change send list
>
> diff --git a/drivers/mtd/devices/bcm47xxsflash.c b/drivers/mtd/devices/bcm47xxsflash.c
> index 9526628..4aa9141 100644
> --- a/drivers/mtd/devices/bcm47xxsflash.c
> +++ b/drivers/mtd/devices/bcm47xxsflash.c
> @@ -76,7 +76,7 @@ static int bcm47xxsflash_bcma_probe(struct platform_device *pdev)
> return 0;
>
> err_dev_reg:
> - kfree(&b47s->mtd);
> + kfree(b47s);
> out:
> return err;
> }
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH RESEND] mtd: fix kfree bcm47xxsflash
2013-05-28 12:40 ` Libo Chen
@ 2013-05-28 12:49 ` Rafał Miłecki
0 siblings, 0 replies; 7+ messages in thread
From: Rafał Miłecki @ 2013-05-28 12:49 UTC (permalink / raw)
To: Libo Chen
Cc: dwmw2, artem.bityutskiy, wfp5p, hauke, linux-mtd, LKML,
Andrew Morton, Li Zefan, Greg KH
2013/5/28 Libo Chen <clbchenlibo.chen@huawei.com>:
> ping...
It takes a lot of time for someone to pick up mtd patches, just be patient ;)
--
Rafał
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH RESEND] mtd: fix kfree bcm47xxsflash
2013-05-22 3:51 ` [PATCH RESEND] " Libo Chen
2013-05-22 5:32 ` Rafał Miłecki
2013-05-28 12:40 ` Libo Chen
@ 2013-05-28 15:29 ` Andy Shevchenko
2013-05-29 2:40 ` Libo Chen
2 siblings, 1 reply; 7+ messages in thread
From: Andy Shevchenko @ 2013-05-28 15:29 UTC (permalink / raw)
To: Libo Chen
Cc: dwmw2, zajec5, artem.bityutskiy, Bill Pemberton, hauke, linux-mtd,
LKML, Andrew Morton, Li Zefan
This is good fix, but I rather prefer not to see it in this shape.
See comments below.
On Wed, May 22, 2013 at 6:51 AM, Libo Chen <clbchenlibo.chen@huawei.com> wrote:
>
> mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its member.
>
> Signed-off-by: Libo Chen <libo.chen@huawei.com>
> Acked-by: Rafał Miłecki <zajec5@gmail.com>
> ---
> drivers/mtd/devices/bcm47xxsflash.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> * add Acked-by: Rafał Miłecki <zajec5@gmail.com>
> * change send list
>
> diff --git a/drivers/mtd/devices/bcm47xxsflash.c b/drivers/mtd/devices/bcm47xxsflash.c
> index 9526628..4aa9141 100644
> --- a/drivers/mtd/devices/bcm47xxsflash.c
> +++ b/drivers/mtd/devices/bcm47xxsflash.c
> @@ -76,7 +76,7 @@ static int bcm47xxsflash_bcma_probe(struct platform_device *pdev)
> return 0;
>
> err_dev_reg:
> - kfree(&b47s->mtd);
> + kfree(b47s);
> out:
> return err;
> }
What about to switch to devm_* and remove those labels and kfrees at all?
Additionally you can add another patch to use module_platform_driver()
macro instead of module_init/exit.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH RESEND] mtd: fix kfree bcm47xxsflash
2013-05-28 15:29 ` Andy Shevchenko
@ 2013-05-29 2:40 ` Libo Chen
0 siblings, 0 replies; 7+ messages in thread
From: Libo Chen @ 2013-05-29 2:40 UTC (permalink / raw)
To: Andy Shevchenko
Cc: dwmw2, zajec5, artem.bityutskiy, Bill Pemberton, hauke, linux-mtd,
LKML, Andrew Morton, Li Zefan
On 2013/5/28 23:29, Andy Shevchenko wrote:
> This is good fix, but I rather prefer not to see it in this shape.
> See comments below.
>
> On Wed, May 22, 2013 at 6:51 AM, Libo Chen <clbchenlibo.chen@huawei.com> wrote:
>>
>> mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its member.
>>
>> Signed-off-by: Libo Chen <libo.chen@huawei.com>
>> Acked-by: Rafał Miłecki <zajec5@gmail.com>
>> ---
>> drivers/mtd/devices/bcm47xxsflash.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> * add Acked-by: Rafał Miłecki <zajec5@gmail.com>
>> * change send list
>>
>> diff --git a/drivers/mtd/devices/bcm47xxsflash.c b/drivers/mtd/devices/bcm47xxsflash.c
>> index 9526628..4aa9141 100644
>> --- a/drivers/mtd/devices/bcm47xxsflash.c
>> +++ b/drivers/mtd/devices/bcm47xxsflash.c
>> @@ -76,7 +76,7 @@ static int bcm47xxsflash_bcma_probe(struct platform_device *pdev)
>> return 0;
>>
>> err_dev_reg:
>> - kfree(&b47s->mtd);
>> + kfree(b47s);
>> out:
>> return err;
>> }
>
> What about to switch to devm_* and remove those labels and kfrees at all?
>
> Additionally you can add another patch to use module_platform_driver()
> macro instead of module_init/exit.
>
ok, I will update later.
thanks,
Libo
> --
> With Best Regards,
> Andy Shevchenko
>
> .
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-05-29 2:42 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-05 8:40 [PATCH] mtd: fix kfree bcm47xxsflash chenlibo.3
2013-05-22 3:51 ` [PATCH RESEND] " Libo Chen
2013-05-22 5:32 ` Rafał Miłecki
2013-05-28 12:40 ` Libo Chen
2013-05-28 12:49 ` Rafał Miłecki
2013-05-28 15:29 ` Andy Shevchenko
2013-05-29 2:40 ` Libo Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox