From: David Vrabel <david.vrabel@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: John Stultz <john.stultz@linaro.org>, <xen-devel@lists.xen.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH 2/2] x86/xen: sync the wallclock when the system time changes
Date: Wed, 29 May 2013 10:37:10 +0100 [thread overview]
Message-ID: <51A5CC46.60508@citrix.com> (raw)
In-Reply-To: <51A5CEB402000078000D97BA@nat28.tlf.novell.com>
On 29/05/13 08:47, Jan Beulich wrote:
>>>> On 28.05.13 at 20:22, David Vrabel <david.vrabel@citrix.com> wrote:
>> @@ -199,28 +201,59 @@ static void xen_get_wallclock(struct timespec *now)
>>
>> static int xen_set_wallclock(const struct timespec *now)
>> {
>> - struct xen_platform_op op;
>> - int ret;
>> -
>> /* do nothing for domU */
>> if (!xen_initial_domain())
>> return -1;
>>
>> - /* Set the Xen wallclock. */
>> + /* Set the hardware RTC. */
>> + return mach_set_rtc_mmss(now);
>> +
>> +}
>
> Can't you achieve the same effect in a cleaner way by overriding
> x86_platform.set_wallclock only in the non-init-domain case?
Yes, that makes sense. John, don't apply this one yet, thanks.
David
next prev parent reply other threads:[~2013-05-29 9:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 18:22 [PATCHv2 0/2] xen: maintain an accurate persistent clock in more cases David Vrabel
2013-05-28 18:22 ` [PATCH 1/2] x86/xen: sync the CMOS RTC as well as the Xen wallclock David Vrabel
2013-05-28 19:01 ` John Stultz
2013-05-28 19:05 ` Konrad Rzeszutek Wilk
2013-05-28 18:22 ` [PATCH 2/2] x86/xen: sync the wallclock when the system time changes David Vrabel
2013-05-28 18:53 ` John Stultz
2013-05-29 7:42 ` [Xen-devel] " Jan Beulich
2013-05-29 9:42 ` David Vrabel
2013-06-04 1:22 ` Marcelo Tosatti
2013-05-29 7:39 ` [Xen-devel] " Jan Beulich
2013-05-29 9:48 ` David Vrabel
2013-05-29 7:47 ` Jan Beulich
2013-05-29 9:37 ` David Vrabel [this message]
2013-05-29 19:58 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A5CC46.60508@citrix.com \
--to=david.vrabel@citrix.com \
--cc=JBeulich@suse.com \
--cc=john.stultz@linaro.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox