Re: [PATCH] net: skbuff: use _RET_IP_

Davidlohr Bueso
2013-05-31T01:11:34Z

On Thu, 2013-05-30 at 13:08 +0200, Bjørn Mork wrote:
> Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> writes:
>
> > Why not "text:%#lx" as already used in this string? It's
> > equivalent to "0x%lx".
>
> Well, I don't know the reasoning in this case, but I'd like to note that
> those are not strictly equivalent. Personally I find the formatting of 0
> annoying enough to avoid %#x for any value which may be 0. It's
> especially bad if you try to line up things by adding leading zeros.

Yep, I found that 0x%lx produced the same output as %p. If you'd rather
I use something else instead, I'm happy to update the patch.

Thanks,
Davidlohr