From: Alexander Holler <holler@ahsoftware.de>
To: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/2] USB: xhci: rename ambiguous named XHCI_NEC_HOST to XHCI_NEC_SHOW_FW
Date: Thu, 30 May 2013 06:16:34 +0200 [thread overview]
Message-ID: <51A6D2A2.30302@ahsoftware.de> (raw)
In-Reply-To: <20130529222500.GC7151@xanatos>
Am 30.05.2013 00:25, schrieb Sarah Sharp:
>
> On Wed, May 29, 2013 at 11:14:32PM +0200, Alexander Holler wrote:
>> Current Renesas Electronics XHCI hosts (which were formerly NEC)
>> do support the same vendor command to show the firmware. Rename the
>> ambigious named define XHCI_NEC_HOST to XHCI_NEC_SHOW_FW because it's
>> only used to display the firmware version. Besides that, change the
>> output "... NEC firmware version x.y" to "... firmware version x.y"
>> to not confuse owners of Renesas USB hosts.
>>
>> (so only cosmetic, no functional changes)
>
> I'm actually inclined to say you should just rip out the firmware
> version code entirely. I haven't needed to use it for years, and if
> Renesas changed their vendor command set, I would rather not submit
> random commands to the host.
>
> So, can you redo this patch to just rip out XHCI_NEC_HOST and everything
> that uses it?
Hmm, I find the firmware version rather informational and would even
display it unconditionally (instead of with xhci_debug). It prevents the
need to boot Windows to checkout if the latest version is installed,
especially if someone is hunting a bug.
I just dont't like the name, because e.g. in my case, it made me to have
a deeper look at what that quirk does, because I had the hope it might
solve a problem. Therefor I think it's useful to rename it.
Regards,
Alexander Holler
next prev parent reply other threads:[~2013-05-30 4:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 21:14 [PATCH 1/2] USB: xhci: rename ambiguous named XHCI_NEC_HOST to XHCI_NEC_SHOW_FW Alexander Holler
2013-05-29 21:14 ` [PATCH 2/2] USB: xhci: show firmware version for Renesas XHCI hosts if debug is enabled Alexander Holler
2013-05-29 22:25 ` [PATCH 1/2] USB: xhci: rename ambiguous named XHCI_NEC_HOST to XHCI_NEC_SHOW_FW Sarah Sharp
2013-05-30 4:16 ` Alexander Holler [this message]
2013-05-30 17:46 ` Alexander Holler
2013-05-30 18:20 ` Sarah Sharp
2013-05-31 0:20 ` Alexander Holler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A6D2A2.30302@ahsoftware.de \
--to=holler@ahsoftware.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sarah.a.sharp@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox