Re: [PATCH v2] arch: m68k: math-emu: unsigned issue, 'unsigned long' will never be less than zero

Chen Gang
2013-06-03T09:11:16Z

On 05/31/2013 05:12 PM, Geert Uytterhoeven wrote:
> On Thu, May 30, 2013 at 10:21 AM, Chen Gang <gang.chen@asianux.com> wrote:
>> 'oldmant.m32[1]' is 'unsigned long' which never '< 0', and the original
>> author wanted to check the highest bit whether set.
>>
>> So need make the bit test explicit (which is better than type cast form
>> 'unsigned long' to 'long').
>>
>> The related warning: (with EXTRA_CFLAGS=-W ARCH=m68k for allmodconfig)
>> arch/m68k/math-emu/fp_arith.c:522:4: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
>>
>> Signed-off-by: Chen Gang <gang.chen@asianux.com>
>
> Thanks, applied and queued for 3.11!
>

Thank you too, and pardon: what is '3.11' ? :-)

Thanks.
--
Chen Gang

Asianux Corporation