Re: [PATCH 7/7] thermal: ti-soc-thermal: add DT example for DRA752 chip

[keerthy <j-keerthy@ti.com>]

Hi Eduardo,

On 05/29/2013 08:37 PM, Eduardo Valentin wrote:

> Update documentation by adding an example for DRA752 on DT description.
> 
> Cc: linux-pm@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Grant Likely <grant.likely@linaro.org>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Cc: Rob Landley <rob@landley.net>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: J Keerthy <j-keerthy@ti.com>
> Cc: devicetree-discuss@lists.ozlabs.org
> Cc: linux-doc@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com>
> ---
>  Documentation/devicetree/bindings/thermal/ti_soc_thermal.txt | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/thermal/ti_soc_thermal.txt b/Documentation/devicetree/bindings/thermal/ti_soc_thermal.txt
> index 1629652..1953b33 100644
> --- a/Documentation/devicetree/bindings/thermal/ti_soc_thermal.txt
> +++ b/Documentation/devicetree/bindings/thermal/ti_soc_thermal.txt
> @@ -59,3 +59,15 @@ bandgap {
>  	compatible = "ti,omap5430-bandgap";
>  	interrupts = <0 126 4>; /* talert */
>  };
> +
> +DRA752:
> +bandgap {
> +	reg = <0x4a0021e0 0xc
> +		0x4a00232c 0xc
> +		0x4a002380 0x2c
> +		0x4a0023C0 0x3c
> +		0x4a002564 0x8
> +		0x4a002574 0x50>;
> +	compatible = "ti,dra752-bandgap";


The general convention seems to be keeping it as dra7xx or dra7.
Why add specific nodes like dra752? We can always reuse for
forthcoming dra7 processors if the same address mapping and IP
is retained right?

> +	interrupts = <0 126 4>; /* talert */


The TRM does not have any term called talert. Can the comment
be /* thermal_alert */ so it is easy to figure out what it is.

> +};


Regards,
Keerthy