From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030296Ab3E3JN6 (ORCPT ); Thu, 30 May 2013 05:13:58 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:48824 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030209Ab3E3JNt (ORCPT ); Thu, 30 May 2013 05:13:49 -0400 Message-ID: <51A71832.70305@ti.com> Date: Thu, 30 May 2013 12:13:22 +0300 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121011 Thunderbird/16.0.1 MIME-Version: 1.0 To: Tony Lindgren CC: , , , Subject: Re: [PATCH] ARM: OMAP2+: omap-usb-host: clean up pin mux setup code References: <1366624673-2684-1-git-send-email-rogerq@ti.com> <20130508235232.GW32546@atomide.com> In-Reply-To: <20130508235232.GW32546@atomide.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/09/2013 02:52 AM, Tony Lindgren wrote: > * Roger Quadros [130422 03:02]: >> The USB host pins are named quite differently between OMAP3 and >> OMAP4+ SoCs. To make this managable in code, we create a pin mapping >> table (pin_names) that maps pin function to pin name. >> >> This pin mapping table is populated at runtime based on a pin >> name template. Templates are provided for OMAP3 and 4 SoCs. >> >> The setup_io_mux() function uses the pin mapping table to >> setup the pin mux. >> >> The resulting code is a lot more clean, manageable and scalable. > > I'm planning to drop all the omap4 pdata soonish. Will post some > patches after -rc1 to do that. Do you still need this patch > considering that? > In that case we don't need this. cheers, -roger