* [patch v2] ipmi: info leak in compat_ipmi_ioctl()
@ 2013-05-31 12:46 Dan Carpenter
2013-05-31 12:58 ` Corey Minyard
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2013-05-31 12:46 UTC (permalink / raw)
To: Corey Minyard; +Cc: openipmi-developer, linux-kernel, kernel-janitors
On x86_64 there is a 4 byte hole between ->recv_type and ->addr.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
v2: fixed the changelog a little. Also added LKML because the
openipmi is a moderated list (and the moderator thought my email was
spam).
diff --git a/drivers/char/ipmi/ipmi_devintf.c b/drivers/char/ipmi/ipmi_devintf.c
index 9eb360f..8e306ac 100644
--- a/drivers/char/ipmi/ipmi_devintf.c
+++ b/drivers/char/ipmi/ipmi_devintf.c
@@ -810,6 +810,7 @@ static long compat_ipmi_ioctl(struct file *filep, unsigned int cmd,
struct ipmi_recv __user *precv64;
struct ipmi_recv recv64;
+ memset(&recv64, 0, sizeof(recv64));
if (get_compat_ipmi_recv(&recv64, compat_ptr(arg)))
return -EFAULT;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch v2] ipmi: info leak in compat_ipmi_ioctl()
2013-05-31 12:46 [patch v2] ipmi: info leak in compat_ipmi_ioctl() Dan Carpenter
@ 2013-05-31 12:58 ` Corey Minyard
0 siblings, 0 replies; 2+ messages in thread
From: Corey Minyard @ 2013-05-31 12:58 UTC (permalink / raw)
To: Dan Carpenter; +Cc: openipmi-developer, linux-kernel, kernel-janitors
On 05/31/2013 07:46 AM, Dan Carpenter wrote:
> On x86_64 there is a 4 byte hole between ->recv_type and ->addr.
Got it, in my tree now. Thanks.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: fixed the changelog a little. Also added LKML because the
> openipmi is a moderated list (and the moderator thought my email was
> spam).
I apologize, the list gets a lot of spam, and I must have made a mistake.
-corey
>
> diff --git a/drivers/char/ipmi/ipmi_devintf.c b/drivers/char/ipmi/ipmi_devintf.c
> index 9eb360f..8e306ac 100644
> --- a/drivers/char/ipmi/ipmi_devintf.c
> +++ b/drivers/char/ipmi/ipmi_devintf.c
> @@ -810,6 +810,7 @@ static long compat_ipmi_ioctl(struct file *filep, unsigned int cmd,
> struct ipmi_recv __user *precv64;
> struct ipmi_recv recv64;
>
> + memset(&recv64, 0, sizeof(recv64));
> if (get_compat_ipmi_recv(&recv64, compat_ptr(arg)))
> return -EFAULT;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-31 12:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-31 12:46 [patch v2] ipmi: info leak in compat_ipmi_ioctl() Dan Carpenter
2013-05-31 12:58 ` Corey Minyard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox