Re: [PATCH v1 8/9] usb: phy: dts: Adding usbphy DT bindings for am33xx

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 24-05-2013 9:34, B, Ravi wrote:

>>>> +		phy1: usbphy-gs70@44e10620 {
>>>> +			compatible = "ti,dsps-usbphy";
>>>> +			reg = <0x44e10620 0x8
>>>> +			       0x44e10648 0x4>;
>>>> +			reg-names = "phy_ctrl","phy_wkup";
>>>> +			id = <0>;
>>>> +		};
>>>> +
>>>> +		phy2: usbphy-gs70@44e10628 {
>>>> +			compatible = "ti,dsps-usbphy";
>>>> +			reg = <0x44e10628 0x8
>>>> +			       0x44e10648 0x4>;
>>> The second register conflicts with phy1.

>> The two instances of phy uses common phy wakeup register.

>>>      That's why there is a resource conflict. Have you actually tried to instantiate the devices out of such tree?
>>> This register should be declared somewhere above the PHYs I think...

> I did not face any problem with this, I have tested both instances of phy used by dual instance controller, worked fine.

    How your /proc/iomem looks like with that?

> What do you suggest, in case of common register which both phy have to use this for wakeup functionality.
> The DT should support this.  What do you suggest in such case?

    I'd probably have to create a third device for this shared register...

> --
> Ravi B

WBR, Sergei