From: Laxman Dewangan <ldewangan@nvidia.com>
To: Mark Brown <broonie@kernel.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"gg@slimlogic.co.uk" <gg@slimlogic.co.uk>,
"ian@slimlogic.co.uk" <ian@slimlogic.co.uk>,
"balbi@ti.com" <balbi@ti.com>
Subject: Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10
Date: Sun, 2 Jun 2013 00:33:10 +0530 [thread overview]
Message-ID: <51AA456E.3030307@nvidia.com> (raw)
In-Reply-To: <20130601184511.GC16790@sirena.org.uk>
On Sunday 02 June 2013 12:15 AM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Thu, May 30, 2013 at 06:30:32PM +0530, Laxman Dewangan wrote:
>
>> Palma have SMPS10 regulator which can generate two voltage level
>> 3.75 and 5V.
>> This SMPS10 has the two outputs OUT1 and OUT2 and having one input IN1.
>> SMPS10-OUT2 is always connected to SMPS10-IN1 via following logic:
>> - Through parasitic diode (no sw control)
>> - In bypass mode (bit configuration is there to enable/disable Bypass)
>> - In Boost mode (bit configuration is there to enable/disable Boost mode)
>> SMPS10-OUT1 is connected to the SMPS10-OUT2 pin through Switch (SW
>> control for enabling/disabling this switch).
>> So I think:
>> regualtor enable/disable, we should toggle the bit for SWITCH.
>> In STANDBY mode, it should be BYPASS disable and Boost disable.
>> In Idle/Normal mode, BYPASS enable and Boost disable.
>> In Fast mode, it should be bypass disable and Boost enable.
> No, that makes no sense at all to me. Why do you think this maps onto
> the set mode API? Modes are all about accuracy of regulation.
I mapped this to the regulation under different load, Fast mode is in
heavy load and so boost enable, normal/idle mode for normal load and so
bypass.
next prev parent reply other threads:[~2013-06-01 19:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 10:56 [RFC PATCH] regulator: palmas: enable all modes for SMPS10 Kishon Vijay Abraham I
2013-05-30 11:32 ` Mark Brown
2013-05-30 12:54 ` Kishon Vijay Abraham I
2013-06-01 18:42 ` Mark Brown
2013-05-30 13:00 ` Laxman Dewangan
2013-06-01 18:45 ` Mark Brown
2013-06-01 19:03 ` Laxman Dewangan [this message]
2013-06-01 21:05 ` Mark Brown
2013-06-04 9:08 ` Kishon Vijay Abraham I
2013-06-04 9:38 ` Mark Brown
2013-06-04 9:43 ` Kishon Vijay Abraham I
2013-06-04 10:05 ` Mark Brown
2013-06-10 9:50 ` Kishon Vijay Abraham I
2013-06-10 10:03 ` Mark Brown
2013-06-10 11:03 ` Kishon Vijay Abraham I
2013-06-10 12:49 ` Mark Brown
2013-06-12 8:42 ` Laxman Dewangan
2013-06-12 14:14 ` Mark Brown
2013-06-12 14:31 ` gg
2013-06-12 14:51 ` Mark Brown
2013-06-12 15:23 ` gg
2013-06-14 12:34 ` Laxman Dewangan
2013-06-18 8:27 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AA456E.3030307@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=balbi@ti.com \
--cc=broonie@kernel.org \
--cc=gg@slimlogic.co.uk \
--cc=ian@slimlogic.co.uk \
--cc=kishon@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox