From: Chen Gang <gang.chen@asianux.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Andreas Schwab <schwab@linux-m68k.org>,
linux-m68k <linux-m68k@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux-Arch <linux-arch@vger.kernel.org>
Subject: Re: [PATCH v2] arch: m68k: math-emu: unsigned issue, 'unsigned long' will never be less than zero
Date: Mon, 03 Jun 2013 17:10:20 +0800 [thread overview]
Message-ID: <51AC5D7C.2000905@asianux.com> (raw)
In-Reply-To: <CAMuHMdWOxh_YvQyid-PiN7FsM=OC=0YWOzJb86pKaQn3HrjaQw@mail.gmail.com>
On 05/31/2013 05:12 PM, Geert Uytterhoeven wrote:
> On Thu, May 30, 2013 at 10:21 AM, Chen Gang <gang.chen@asianux.com> wrote:
>> 'oldmant.m32[1]' is 'unsigned long' which never '< 0', and the original
>> author wanted to check the highest bit whether set.
>>
>> So need make the bit test explicit (which is better than type cast form
>> 'unsigned long' to 'long').
>>
>> The related warning: (with EXTRA_CFLAGS=-W ARCH=m68k for allmodconfig)
>> arch/m68k/math-emu/fp_arith.c:522:4: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
>>
>> Signed-off-by: Chen Gang <gang.chen@asianux.com>
>
> Thanks, applied and queued for 3.11!
>
Thank you too, and pardon: what is '3.11' ? :-)
Thanks.
--
Chen Gang
Asianux Corporation
next prev parent reply other threads:[~2013-06-03 9:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 6:25 [PATCH] arch: m68k: math-emu: unsigned issue, 'unsigned long' will never be less than zero Chen Gang
2013-05-30 7:09 ` Andreas Schwab
2013-05-30 8:08 ` Chen Gang
2013-05-30 8:21 ` [PATCH v2] " Chen Gang
2013-05-31 9:12 ` Geert Uytterhoeven
2013-06-03 9:10 ` Chen Gang [this message]
2013-06-03 9:13 ` Geert Uytterhoeven
2013-06-03 9:22 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AC5D7C.2000905@asianux.com \
--to=gang.chen@asianux.com \
--cc=geert@linux-m68k.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox