public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: Avi Kivity <avi.kivity@gmail.com>, kvm <kvm@vger.kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: fix sil/dil/bpl/spl in the mod/rm fields
Date: Mon, 03 Jun 2013 18:58:43 +0200	[thread overview]
Message-ID: <51ACCB43.50803@redhat.com> (raw)
In-Reply-To: <20130603164057.GQ24773@redhat.com>

Il 03/06/2013 18:40, Gleb Natapov ha scritto:
>> > Won't work, vmx won't let you enter in such a configuration.
> 
> Why? It is possible to have NULL descriptor in 32bit mode with vmx. But
> we do not usually intercept #GP while executing 32bit mode, so we will
> have to track if there is artificial NULL selector and enables #GP
> interception and then emulate on every #GP.

Yes, that's what I had in mind.  Of course for invalid CS you do have to
emulate.

>> > Maybe you can detect the exact code sequence (%eip, some instructions,
>> > register state) and clear %fs and %gs.
> My be we can set dpl to rpl unconditionally on a switch from 16 to 32
> bit. The only problem I can see with it is that if a guest enters user
> mode without explicitly reload the segment it will be accessible by a
> user mode code, but I am not sure it is well defined what dpl of a 16
> bit segment is after transition to 32 bit mode anyway, so it would be
> crazy to do so.

That too, or just set it to 3.  But perhaps the #GP interception
wouldn't be too hard.

Paolo

  reply	other threads:[~2013-06-03 16:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-30 14:35 [PATCH] KVM: fix sil/dil/bpl/spl in the mod/rm fields Paolo Bonzini
2013-05-30 15:34 ` Paolo Bonzini
2013-05-30 16:34   ` Paolo Bonzini
2013-06-03 15:42     ` Avi Kivity
2013-06-03 16:40       ` Gleb Natapov
2013-06-03 16:58         ` Paolo Bonzini [this message]
     [not found]         ` <CAEbWairziqNjujCdGmMsQsb0mqX6HXjyVcJvGriY0wgjJBxjnQ@mail.gmail.com>
2013-06-03 17:45           ` Gleb Natapov
2013-06-03 10:25   ` Gleb Natapov
2013-06-03 12:53     ` Paolo Bonzini
2013-06-02 18:12 ` Gleb Natapov
2013-06-03  6:27   ` Paolo Bonzini
2013-06-03  8:04     ` Gleb Natapov
2013-06-03  8:15       ` Paolo Bonzini
2013-06-03  8:28 ` Gleb Natapov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51ACCB43.50803@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=avi.kivity@gmail.com \
    --cc=gleb@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox