From: Ben Greear <greearb@candelatech.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
Thomas Gleixner <tglx@linutronix.de>
Subject: 3.9.x: Possible race related to stop_machine leads to lockup.
Date: Tue, 04 Jun 2013 14:18:16 -0700 [thread overview]
Message-ID: <51AE5998.2060204@candelatech.com> (raw)
I've been trying to figure out why I see the migration/* processes
hang in a busy loop....
While reading the stop_machine.c file, I think I might have an
answer.
The set_state() method sets the thread_ack to the current number
of threads. Each thread's state machine then decrements it down to
zero where it bumps the state to the next level. This lets each
cpu stop in lock-step it seems.
But, from what I can tell, the __stop_machine() method can
(re)set the state to STOPMACHINE_PREPARE while the migration
processes are in their loop. That would explain why they sometimes
loop forever.
Does this make sense?
Any ideas on how to fix this properly?
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next reply other threads:[~2013-06-04 21:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-04 21:18 Ben Greear [this message]
2013-06-04 22:13 ` 3.9.x: Possible race related to stop_machine leads to lockup Ben Greear
2013-06-05 4:41 ` Rusty Russell
2013-06-05 15:11 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AE5998.2060204@candelatech.com \
--to=greearb@candelatech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox