From: Michael Wang <wangyun@linux.vnet.ibm.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Borislav Petkov <bp@alien8.de>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Tony Luck <tony.luck@intel.com>,
linux-kernel@vger.kernel.org, x86@kernel.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: NOHZ: WARNING: at arch/x86/kernel/smp.c:123 native_smp_send_reschedule, round 2
Date: Wed, 05 Jun 2013 10:30:00 +0800 [thread overview]
Message-ID: <51AEA2A8.90605@linux.vnet.ibm.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1306042319360.6750@pobox.suse.cz>
Hi, Jiri
On 06/05/2013 05:20 AM, Jiri Kosina wrote:
[snip]
>
> Just to not let this thread sleep -- I am seeing this as well, even with
> current Linus' tree (git HEAD == aa4f608).
Have you tried this:
diff --git a/drivers/cpufreq/cpufreq_governor.c
b/drivers/cpufreq/cpufreq_governor.c
index 443442d..449be88 100644
--- a/drivers/cpufreq/cpufreq_governor.c
+++ b/drivers/cpufreq/cpufreq_governor.c
@@ -26,6 +26,7 @@
#include <linux/tick.h>
#include <linux/types.h>
#include <linux/workqueue.h>
+#include <linux/cpu.h>
#include "cpufreq_governor.h"
@@ -180,8 +181,10 @@ void gov_queue_work(struct dbs_data *dbs_data,
struct cpufreq_policy *policy,
if (!all_cpus) {
__gov_queue_work(smp_processor_id(), dbs_data, delay);
} else {
+ get_online_cpus();
for_each_cpu(i, policy->cpus)
__gov_queue_work(i, dbs_data, delay);
+ put_online_cpus();
}
}
EXPORT_SYMBOL_GPL(gov_queue_work);
Does it works?
Regards,
Michael Wang
>
next prev parent reply other threads:[~2013-06-05 2:30 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 12:29 NOHZ: WARNING: at arch/x86/kernel/smp.c:123 native_smp_send_reschedule Jiri Kosina
2013-05-09 12:50 ` Borislav Petkov
2013-05-09 12:58 ` Borislav Petkov
2013-05-15 18:45 ` Paul E. McKenney
2013-05-15 22:43 ` Borislav Petkov
2013-05-15 23:55 ` Paul E. McKenney
2013-05-17 13:56 ` NOHZ: WARNING: at arch/x86/kernel/smp.c:123 native_smp_send_reschedule, round 2 Borislav Petkov
2013-05-20 3:16 ` Michael Wang
2013-05-20 4:50 ` Borislav Petkov
2013-05-20 6:23 ` Michael Wang
2013-05-20 6:47 ` Borislav Petkov
2013-05-20 6:58 ` Michael Wang
2013-05-20 7:06 ` Michael Wang
2013-05-20 7:12 ` Viresh Kumar
2013-05-20 7:25 ` Michael Wang
2013-05-20 8:56 ` Michael Wang
2013-05-20 9:09 ` Viresh Kumar
2013-05-20 9:24 ` Michael Wang
2013-05-20 13:23 ` Borislav Petkov
2013-05-20 13:43 ` Viresh Kumar
2013-05-20 15:08 ` Borislav Petkov
2013-05-21 2:20 ` Michael Wang
2013-05-21 2:37 ` Michael Wang
2013-05-21 7:21 ` Borislav Petkov
2013-05-21 7:58 ` Michael Wang
2013-05-20 7:36 ` Tejun Heo
2013-05-20 8:10 ` Frederic Weisbecker
2013-05-20 9:31 ` Srivatsa S. Bhat
2013-05-20 9:40 ` Viresh Kumar
2013-05-20 10:24 ` Viresh Kumar
2013-06-04 21:20 ` Jiri Kosina
2013-06-05 2:30 ` Michael Wang [this message]
2013-06-05 8:08 ` Jiri Kosina
2013-06-05 8:12 ` Michael Wang
2013-05-10 0:29 ` NOHZ: WARNING: at arch/x86/kernel/smp.c:123 native_smp_send_reschedule Frederic Weisbecker
2013-05-10 9:28 ` Borislav Petkov
2013-05-10 9:26 ` Frederic Weisbecker
2013-05-10 9:37 ` Ingo Molnar
2013-05-10 9:45 ` Borislav Petkov
2013-05-10 15:31 ` Frederic Weisbecker
2013-05-10 9:43 ` Borislav Petkov
2013-05-10 15:42 ` Jiri Kosina
2013-05-10 15:03 ` Jiri Kosina
2013-05-10 15:21 ` Borislav Petkov
2013-05-10 15:43 ` Frederic Weisbecker
2013-05-10 16:23 ` Borislav Petkov
2013-05-10 21:38 ` Frederic Weisbecker
2013-05-13 14:56 ` Jiri Kosina
2013-05-13 19:40 ` Thomas Gleixner
2013-05-13 20:01 ` Jiri Kosina
2013-05-14 15:46 ` [tip:timers/urgent] tick: Don't invoke tick_nohz_stop_sched_tick( ) if the cpu is offline tip-bot for Thomas Gleixner
2013-05-15 19:41 ` Frederic Weisbecker
2013-05-16 14:06 ` Thomas Gleixner
2013-05-16 14:15 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AEA2A8.90605@linux.vnet.ibm.com \
--to=wangyun@linux.vnet.ibm.com \
--cc=bp@alien8.de \
--cc=fweisbec@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox