From: Michael Wang <wangyun@linux.vnet.ibm.com>
To: Tejun Heo <tj@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 3/3] workqueue: add a check point in pwq_activate_delayed_work()
Date: Wed, 05 Jun 2013 15:11:35 +0800 [thread overview]
Message-ID: <51AEE4A7.6050808@linux.vnet.ibm.com> (raw)
In-Reply-To: <51AEE452.8080605@linux.vnet.ibm.com>
get_work_pwq() is possible to return NULL, add a check point for that in
the context inside pwq_activate_delayed_work().
CC: Tejun Heo <tj@kernel.org>
Signed-off-by: Michael Wang <wangyun@linux.vnet.ibm.com>
---
kernel/workqueue.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index ee8e29a..ea2ec38 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -1072,6 +1072,7 @@ static void put_pwq_unlocked(struct pool_workqueue *pwq)
static void pwq_activate_delayed_work(struct work_struct *work)
{
struct pool_workqueue *pwq = get_work_pwq(work);
+ BUG_ON(!pwq);
trace_workqueue_activate_work(work);
move_linked_works(work, &pwq->pool->worklist, NULL);
--
1.7.4.1
next prev parent reply other threads:[~2013-06-05 7:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 7:10 [PATCH 0/3] workqueue: code refine/clean for workqueue Michael Wang
2013-06-05 7:10 ` [PATCH 1/3] workqueue: move the internal helper from .h to .c Michael Wang
2013-06-05 7:19 ` Tejun Heo
2013-06-05 7:11 ` [PATCH 2/3] workqueue: remove the unused helper in .h Michael Wang
2013-06-05 7:24 ` Tejun Heo
2013-06-05 7:11 ` Michael Wang [this message]
2013-06-05 7:17 ` [PATCH 3/3] workqueue: add a check point in pwq_activate_delayed_work() Tejun Heo
2013-06-05 7:14 ` [PATCH 4/3] workqueue: code refine in wqattrs_equal() Michael Wang
2013-06-05 7:21 ` Tejun Heo
2013-06-05 7:15 ` [PATCH 0/3] workqueue: code refine/clean for workqueue Michael Wang
2013-06-05 7:39 ` Michael Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AEE4A7.6050808@linux.vnet.ibm.com \
--to=wangyun@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox