From: Srinivas KANDAGATLA <srinivas.kandagatla@st.com>
To: Mark Brown <broonie@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC] regmap: Add regmap_field APIs
Date: Wed, 05 Jun 2013 15:41:29 +0100 [thread overview]
Message-ID: <51AF4E19.8050509@st.com> (raw)
In-Reply-To: <20130605114140.GW31367@sirena.org.uk>
Thankyou for reviewing the patch.
On 05/06/13 12:41, Mark Brown wrote:
> On Wed, Jun 05, 2013 at 10:21:23AM +0100, Srinivas KANDAGATLA wrote:
> I think I'd prefer to see a struct passed in here for the field
> definition - this would make it easier to initialise from static data,
> otherwise people will end up writing a loop that reads from a locally
> defined struct once they get more than a couple of fields.
>
I will modify the APIs to take reg_field structure instead of reg, lsb,
and msb arguments.
Is it Ok If I send this patch with my "STiH41x SOC support series", as
we can see the actual usage of this new apis in the follow on patches?
Thanks,
srini
> Otherwise this makes sense.
>
next prev parent reply other threads:[~2013-06-05 14:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 14:58 [RFC] regmap: Add regmap_field APIs Srinivas KANDAGATLA
2013-05-31 6:31 ` Srinivas KANDAGATLA
2013-06-01 18:38 ` Mark Brown
2013-06-04 21:01 ` Mark Brown
2013-06-05 9:21 ` Srinivas KANDAGATLA
2013-06-05 11:41 ` Mark Brown
2013-06-05 14:41 ` Srinivas KANDAGATLA [this message]
2013-06-05 15:59 ` Mark Brown
2013-06-09 16:00 ` Lars-Peter Clausen
2013-06-10 7:09 ` Srinivas KANDAGATLA
2013-06-10 9:15 ` Mark Brown
2013-06-10 10:27 ` Srinivas KANDAGATLA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AF4E19.8050509@st.com \
--to=srinivas.kandagatla@st.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox