From: Mark Langsdorf <mark.langsdorf@calxeda.com>
To: Tejun Heo <tj@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
Rob Herring <rob.herring@calxeda.com>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>
Subject: Re: [PATCH 2/2] sata highbank: add bit-banged SGPIO driver support
Date: Thu, 06 Jun 2013 07:14:08 -0500 [thread overview]
Message-ID: <51B07D10.2060609@calxeda.com> (raw)
In-Reply-To: <20130605231517.GP10693@mtj.dyndns.org>
,On 06/05/2013 06:15 PM, Tejun Heo wrote:
> Hello,
>
> On Wed, Jun 05, 2013 at 05:31:48PM -0500, Mark Langsdorf wrote:
>> +static void ecx_parse_sgpio(struct ecx_plat_data *pdata, u32 port, u32 state)
>> +{
>> + if (state & ECX_ACTIVITY_BITS)
>> + pdata->sgpio_pattern |= sgpio_bit_shift(pdata, port,
>> + ECX_ACTIVITY_SHIFT);
>> + else
>> + pdata->sgpio_pattern &= sgpio_bit_shift(pdata, port,
>> + ECX_ACTIVITY_SHIFT);
>
> Shouldn't it be "&= ~" instead of "&="? You're trying to turn the bit
> off, right?
Oops. Thanks!
--Mark Langsdorf
Calxeda, Inc.
next prev parent reply other threads:[~2013-06-06 12:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 20:17 [PATCH 1/2] ahci: make ahci_transmit_led_message into a function pointer Mark Langsdorf
2013-05-30 20:17 ` [PATCH 2/2] sata highbank: add bit-banged SGPIO driver support Mark Langsdorf
2013-05-31 1:17 ` Tejun Heo
2013-06-03 13:35 ` [PATCH 2/2 v2] " Mark Langsdorf
2013-06-03 20:37 ` Tejun Heo
2013-06-04 15:09 ` Mark Langsdorf
2013-06-04 20:32 ` Tejun Heo
2013-06-05 20:19 ` Mark Langsdorf
2013-06-05 22:31 ` [PATCH 2/2] " Mark Langsdorf
2013-06-05 23:15 ` Tejun Heo
2013-06-06 12:14 ` Mark Langsdorf [this message]
2013-06-06 12:52 ` [PATCH 2/2 v4] " Mark Langsdorf
2013-06-06 21:06 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B07D10.2060609@calxeda.com \
--to=mark.langsdorf@calxeda.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@linaro.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox