Re: [PATCH] GFS2: minor readability improvement in gfs2_mount()

Steven Whitehouse
2013-06-06T09:27:18Z

Hi,

On Thu, 2013-06-06 at 01:29 +0400, Alexey Khoroshilov wrote:
> The patch makes usage pattern of IS_ERR-PTR_ERR more typical.
>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
> ---
> fs/gfs2/ops_fstype.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c
> index 0262c19..0d30e8e 100644
> --- a/fs/gfs2/ops_fstype.c
> +++ b/fs/gfs2/ops_fstype.c
> @@ -1313,9 +1313,10 @@ static struct dentry *gfs2_mount(struct file_system_type *fs_type, int flags,
> }
> s = sget(fs_type, test_gfs2_super, set_gfs2_super, flags, bdev);
> mutex_unlock(&bdev->bd_fsfreeze_mutex);
> - error = PTR_ERR(s);
> - if (IS_ERR(s))
> + if (IS_ERR(s)) {
> + error = PTR_ERR(s);
> goto error_bdev;
> + }
I'm not sure what you are getting at here. Why add a jump into the fast
path?

Steve.

>
> if (s->s_root)
> blkdev_put(bdev, mode);