From: Hector Palacios <hector.palacios@digi.com>
To: "maxime.ripard@free-electrons.com" <maxime.ripard@free-electrons.com>
Cc: Juergen Beisert <jbe@pengutronix.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"fabio.estevam@freescale.com" <fabio.estevam@freescale.com>,
"brian@crystalfontz.com" <brian@crystalfontz.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>
Subject: Re: mxsfb: DATA_FORMAT_24_BIT flag outputs invalid colours
Date: Fri, 7 Jun 2013 09:28:32 +0200 [thread overview]
Message-ID: <51B18BA0.50506@digi.com> (raw)
In-Reply-To: <20130607072103.GF14209@lukather>
Hi Maxime,
On 06/07/2013 09:21 AM, maxime.ripard@free-electrons.com wrote:
> Hi Hector,
>
> On Fri, May 24, 2013 at 03:33:19PM +0200, Juergen Beisert wrote:
>> Someone told me, Qt5 cannot handle this special RGB666 mode (even not the
>> def_rgb666_shift memory layout mentioned above). My test are based on Qt4.
>> Qt5 needs a regular RGB888 mode, which should silently be converted
>> internally to RGB666 in the hardware.
>>
>> So, your patch to always use the RGB888 memory layout seems to be the right
>> way to go.
>
> Do you plan on submitting this patch? (Or did you already submit it and
> I overlooked it?)
I wasn't sure that everybody involved agreed with the patch.
@Juergen, would the patch break your platform?
Additionally, the guys from Crystalfontz didn't comment on it, but their platform is
also using a 18bit data bus width and 32bpp.
If no-one is against I'll be glad to submit it.
Best regards,
--
Hector Palacios
next prev parent reply other threads:[~2013-06-07 7:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 11:55 mxsfb: DATA_FORMAT_24_BIT flag outputs invalid colours Hector Palacios
2013-05-23 13:00 ` maxime.ripard
2013-05-23 13:31 ` Juergen Beisert
2013-05-23 15:56 ` Hector Palacios
2013-05-24 10:28 ` Juergen Beisert
2013-05-24 10:43 ` Hector Palacios
2013-05-24 11:00 ` Juergen Beisert
2013-05-24 13:33 ` Juergen Beisert
2013-06-07 7:21 ` maxime.ripard
2013-06-07 7:28 ` Hector Palacios [this message]
2013-06-07 7:34 ` Juergen Beisert
2013-06-07 7:42 ` maxime.ripard
2013-06-07 8:10 ` [PATCH] video: mxsfb: fix color settings for 18bit data bus and 32bpp Hector Palacios
2013-06-07 9:02 ` maxime.ripard
2013-06-18 8:32 ` maxime.ripard
2013-06-18 8:45 ` Hector Palacios
2013-05-24 8:11 ` mxsfb: DATA_FORMAT_24_BIT flag outputs invalid colours maxime.ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B18BA0.50506@digi.com \
--to=hector.palacios@digi.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=brian@crystalfontz.com \
--cc=fabio.estevam@freescale.com \
--cc=jbe@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox