* [PATCH][RESEND] Silence noisy per-device cciss messages
@ 2013-06-07 13:16 Bryn M. Reeves
2013-06-07 18:16 ` Mike Miller (OS Dev)
0 siblings, 1 reply; 2+ messages in thread
From: Bryn M. Reeves @ 2013-06-07 13:16 UTC (permalink / raw)
To: LKML; +Cc: mike.miller, scameron, thenzl, axboe
[-- Attachment #1: Type: text/plain, Size: 488 bytes --]
Currently cciss logs a message each time cciss_read_capacity_16 is called:
kernel: cciss 0000:03:00.0: blocks= 5274326576 block_size= 512
This generates considerable log noise. An identical message was deleted
from cciss_read_capacity in 2009.
This patch mirrors the change made to cciss_read_capacity in commit
983333c. Emitting device and block size information at KERN_INFO on
each read_capacity() leads to a lot of log noise.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
[-- Attachment #2: 0001-Silence-noisy-per-device-cciss-messages.patch --]
[-- Type: text/x-patch, Size: 947 bytes --]
>From da8267e5452e03158da8dd27026fb7188342d653 Mon Sep 17 00:00:00 2001
From: "Bryn M. Reeves" <bmr@redhat.com>
Date: Fri, 7 Jun 2013 13:45:10 +0100
Subject: [PATCH] Silence noisy per-device cciss messages
This patch mirrors the change made to cciss_read_capacity in commit
983333c. Emitting device and block size information at KERN_INFO on
each read_capacity() leads to a lot of log noise.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
---
drivers/block/cciss.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
index 6374dc1..b128016 100644
--- a/drivers/block/cciss.c
+++ b/drivers/block/cciss.c
@@ -2937,8 +2937,6 @@ static void cciss_read_capacity_16(ctlr_info_t *h, int logvol,
*total_size = 0;
*block_size = BLOCK_SIZE;
}
- dev_info(&h->pdev->dev, " blocks= %llu block_size= %d\n",
- (unsigned long long)*total_size+1, *block_size);
kfree(buf);
}
--
1.7.11.7
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][RESEND] Silence noisy per-device cciss messages
2013-06-07 13:16 [PATCH][RESEND] Silence noisy per-device cciss messages Bryn M. Reeves
@ 2013-06-07 18:16 ` Mike Miller (OS Dev)
0 siblings, 0 replies; 2+ messages in thread
From: Mike Miller (OS Dev) @ 2013-06-07 18:16 UTC (permalink / raw)
To: Bryn M. Reeves; +Cc: LKML, scameron, thenzl, axboe
On Fri, 2013-06-07 at 14:16 +0100, Bryn M. Reeves wrote:
> Currently cciss logs a message each time cciss_read_capacity_16 is called:
>
> kernel: cciss 0000:03:00.0: blocks= 5274326576 block_size= 512
>
> This generates considerable log noise. An identical message was deleted
> from cciss_read_capacity in 2009.
>
> This patch mirrors the change made to cciss_read_capacity in commit
> 983333c. Emitting device and block size information at KERN_INFO on
> each read_capacity() leads to a lot of log noise.
>
> Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
Acked-by: Mike Miller <mike.miller@hp.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-07 18:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-07 13:16 [PATCH][RESEND] Silence noisy per-device cciss messages Bryn M. Reeves
2013-06-07 18:16 ` Mike Miller (OS Dev)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox