From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756797Ab3FGWTj (ORCPT ); Fri, 7 Jun 2013 18:19:39 -0400 Received: from mail-wg0-f54.google.com ([74.125.82.54]:38377 "EHLO mail-wg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752999Ab3FGWTi (ORCPT ); Fri, 7 Jun 2013 18:19:38 -0400 Message-ID: <51B25C77.8080902@linaro.org> Date: Sat, 08 Jun 2013 00:19:35 +0200 From: Daniel Lezcano User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Thomas Gleixner CC: Linux Kernel Mailing List Subject: Re: [RFC] add a WARN in setup_irq function for the IRQF_DISABLED flag References: <51B25BEC.5050003@linaro.org> In-Reply-To: <51B25BEC.5050003@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/08/2013 12:17 AM, Daniel Lezcano wrote: > > Hi, > > we are still seeing drivers with the irq flag IRQF_DISABLED present and > *new* drivers submitted with this flag set. > > I am wondering if we can add a WARN in the setup_irq function about this > flag. May be it is a bit rough but people will pay attention. s/rough/brutal :) > Thanks > > -- Daniel > > Index: clockevents/kernel/irq/manage.c > =================================================================== > --- clockevents.orig/kernel/irq/manage.c 2013-06-05 > 23:57:22.723446115 +0200 > +++ clockevents/kernel/irq/manage.c 2013-06-08 00:12:19.985035465 +0200 > @@ -1212,6 +1212,9 @@ int setup_irq(unsigned int irq, struct i > > if (WARN_ON(irq_settings_is_per_cpu_devid(desc))) > return -EINVAL; > + > + WARN(act->flags & IRQF_DISABLED, "IRQF_DISABLED flag is disabled"); > + > chip_bus_lock(desc); > retval = __setup_irq(irq, desc, act); > chip_bus_sync_unlock(desc); > -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog