Re: [PATCH v2 0/3] Increase the number of USB to serial devices we can support at once

[Tobias Winter <tobias@linuxdingsda.de>]

[-- Attachment #1: Type: text/plain, Size: 1298 bytes --]

On 06/07/2013 07:25 PM, Greg KH wrote:
> On Fri, Jun 07, 2013 at 11:55:59AM +0200, Tobias Winter wrote:
>> On 06/07/2013 08:00 AM, Tobias Winter wrote:
>>>   CC      drivers/usb/serial/console.o
>>> drivers/usb/serial/console.c: In function ‘usb_console_setup’:
>>> drivers/usb/serial/console.c:111:2: error: implicit declaration of
>>> function ‘usb_serial_get_by_index’ [-Werror=implicit-function-declaration]
>>> drivers/usb/serial/console.c:111:9: warning: assignment makes pointer
>>> from integer without a cast [enabled by default]
>>> drivers/usb/serial/console.c:122:40: error: ‘struct usb_serial’ has no
>>> member named ‘minor’
>>> cc1: some warnings being treated as errors
>>> make[4]: *** [drivers/usb/serial/console.o] Error 1
>>> make[3]: *** [drivers/usb/serial] Error 2
>>> make[2]: *** [drivers/usb] Error 2
>>> make[1]: *** [drivers] Error 2
>>> make[1]: Leaving directory `/root/usb.git'
>>> make: *** [debian/stamp/build/kernel] Error 2
>>
>> Despite that broken driver, I just gave it a try and the patchset works
>> as expected.
> 
> Thanks for testing, I forgot to update the console code, as no one sane
> every runs it :)
> 
> I'll go fix that up now...
I just retested it and it works as expected.

Thanks, Greg!

Tobias


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]