From: Chen Gang <gang.chen@asianux.com>
To: rth@twiddle.net, ink@jurassic.park.msu.ru, mattst88@gmail.com,
"dhowells@redhat.com" <dhowells@redhat.com>,
tony.luck@intel.com, fenghua.yu@intel.com,
yasutake.koichi@jp.panasonic.com
Cc: linux-alpha@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-ia64@vger.kernel.org, linux-am33-list@redhat.com,
Linux-Arch <linux-arch@vger.kernel.org>
Subject: [Suggestion] arch/*/include/asm/bitops.h: about __set_bit() API.
Date: Sat, 08 Jun 2013 18:08:05 +0800 [thread overview]
Message-ID: <51B30285.6020503@asianux.com> (raw)
Hello Maintainers:
Several architectures have different __set_bit() API to others, in
standard API, 2nd param of __set_bit() is 'unsigned long *', but:
in 'min10300', it is 'unsigned char *',
in 'ia64' and 'alpha', they are 'int' or 'unsigned int'.
If another sub-systems did not notice it, it may lead them to make
mistakes.
It seems related maintainer intended to implement it like that.
So could related maintainers provide the reason for it, so more guys
(e.g. me) can learn about it (at least can avoid related mistakes).
The related information in arch sub-system:
using 'unsigned char *':
./mn10300/include/asm/bitops.h:28:#define __set_bit(nr, addr) \
using 'unsigned int *', implicitly:
./ia64/include/asm/bitops.h:63:__set_bit (int nr, volatile void *addr)
using 'int *', implicitly: (need use 'unsigned', at least)
./alpha/include/asm/bitops.h:49:__set_bit(unsigned long nr, volatile void * addr)
using 'unsigned long *' implicitly:
./frv/include/asm/bitops.h:164:static inline void __set_bit(unsigned long nr, volatile void *addr)
standard API:
./h8300/include/asm/bitops.h:74:#define __set_bit(nr,addr) set_bit((nr),(addr))
./m68k/include/asm/bitops.h:67:#define __set_bit(nr, vaddr) set_bit(nr, vaddr)
./arc/include/asm/bitops.h:293:static inline void __set_bit(unsigned long nr, volatile unsigned long *m)
./sh/include/asm/bitops-op32.h:20:static inline void __set_bit(int nr, volatile unsigned long *addr)
./hexagon/include/asm/bitops.h:151:static inline void __set_bit(int nr, volatile unsigned long *addr)
./s390/include/asm/bitops.h:212:static inline void __set_bit(unsigned long nr, volatile unsigned long *ptr)
./x86/include/asm/bitops.h:84:static inline void __set_bit(int nr, volatile unsigned long *addr)
(others use 'generic')
Thanks.
--
Chen Gang
Asianux Corporation
next reply other threads:[~2013-06-08 10:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-08 10:08 Chen Gang [this message]
2013-06-10 22:26 ` [Suggestion] arch/*/include/asm/bitops.h: about __set_bit() API Tony Luck
2013-06-11 7:32 ` Geert Uytterhoeven
2013-06-13 2:43 ` Chen Gang
2013-06-13 2:30 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B30285.6020503@asianux.com \
--to=gang.chen@asianux.com \
--cc=dhowells@redhat.com \
--cc=fenghua.yu@intel.com \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-am33-list@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mattst88@gmail.com \
--cc=rth@twiddle.net \
--cc=tony.luck@intel.com \
--cc=yasutake.koichi@jp.panasonic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox