From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
Cc: Joe Perches <joe@perches.com>,
Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Vineet Gupta <Vineet.Gupta1@synopsys.com>,
"Mischa Jonker" <Mischa.Jonker@synopsys.com>,
Arnd Bergmann <arnd@arndb.de>,
"Grant Likely" <grant.likely@linaro.org>,
Rob Herring <rob.herring@calxeda.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
"David S. Miller" <davem@davemloft.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"romieu@fr.zoreil.com" <romieu@fr.zoreil.com>
Subject: Re: [PATCH v2] ethernet/arc/arc_emac - Add new driver
Date: Sat, 8 Jun 2013 16:53:46 +0530 [thread overview]
Message-ID: <51B31442.5020707@synopsys.com> (raw)
In-Reply-To: <4881796E12491D4BB15146FE0209CE643F5CA32B@DE02WEMBXB.internal.synopsys.com>
On 06/08/2013 04:49 PM, Alexey Brodkin wrote:
> >> + if (!priv->phy_node) {
> >> + dev_err(&pdev->dev, "failed to retrieve phy description "
> >> + "from device tree\n");
> >
> > Coalesce formats please
>
> Could you please clarify how should I format lines in question?
> I'm a bit lost here.
Don't break the string - even if line becomes > 80 chars. This is to help with
grep and such.
-Vineet
next prev parent reply other threads:[~2013-06-08 11:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 15:07 [PATCH v2] ethernet/arc/arc_emac - Add new driver Alexey Brodkin
2013-06-07 15:39 ` Arnd Bergmann
2013-06-07 18:13 ` Joe Perches
2013-06-08 11:19 ` Alexey Brodkin
2013-06-08 11:23 ` Vineet Gupta [this message]
2013-06-07 20:32 ` Francois Romieu
2013-06-09 8:53 ` Alexey Brodkin
2013-06-09 22:15 ` Francois Romieu
2013-06-09 18:16 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B31442.5020707@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=Alexey.Brodkin@synopsys.com \
--cc=Mischa.Jonker@synopsys.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@linaro.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=rob.herring@calxeda.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox