From: Lars-Peter Clausen <lars@metafoo.de>
To: Vinod Koul <vinod.koul@intel.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Maarten ter Huurne <maarten@treewalker.org>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org
Subject: Re: [PATCH v2 3/6] dma: Add a jz4740 dmaengine driver
Date: Mon, 10 Jun 2013 19:29:46 +0200 [thread overview]
Message-ID: <51B60D0A.7040307@metafoo.de> (raw)
In-Reply-To: <51A79E8F.4070209@metafoo.de>
On 05/30/2013 08:46 PM, Lars-Peter Clausen wrote:
>>> +static int jz4740_dma_alloc_chan_resources(struct dma_chan *c)
>>> +{
>>> + struct jz4740_dmaengine_chan *chan = to_jz4740_dma_chan(c);
>>> +
>>> + chan->jz_chan = jz4740_dma_request(chan, NULL);
>>> + if (!chan->jz_chan)
>>> + return -EBUSY;
>>> +
>>> + jz4740_dma_set_complete_cb(chan->jz_chan, jz4740_dma_complete_cb);
>>> +
>>> + return 0;
>> Sorry, I didnt reply on this one. The API expects you to allocate a pool of
>> descriptors. These descriptors are to be used in .device_prep_xxx calls later.
>
> The size of the descriptor is not fixed, so they can not be pre-allocated. And
> this is nothing new either, most of the more recently added dmaengine drivers
> allocate their descriptors on demand.
Vinod, are you ok with this explanation?
- Lars
next prev parent reply other threads:[~2013-06-10 17:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 16:24 [PATCH 0/6] Convert JZ4740 to dmaengine Lars-Peter Clausen
2013-05-30 16:25 ` [PATCH v2 1/6] MIPS: jz4740: Correct clock gate bit for DMA controller Lars-Peter Clausen
2013-05-30 16:25 ` [PATCH v2 2/6] MIPS: jz4740: Acquire and enable DMA controller clock Lars-Peter Clausen
2013-05-30 16:25 ` [PATCH v2 3/6] dma: Add a jz4740 dmaengine driver Lars-Peter Clausen
2013-05-30 17:12 ` Vinod Koul
2013-05-30 18:46 ` Lars-Peter Clausen
2013-06-10 17:29 ` Lars-Peter Clausen [this message]
2013-06-12 5:38 ` Vinod Koul
2013-06-12 12:07 ` [alsa-devel] " Lars-Peter Clausen
2013-06-21 10:51 ` Vinod Koul
2013-05-30 16:25 ` [PATCH v2 4/6] MIPS: jz4740: Register jz4740 DMA device Lars-Peter Clausen
2013-05-30 17:24 ` Sergei Shtylyov
2013-06-10 17:30 ` Lars-Peter Clausen
2013-05-30 16:25 ` [PATCH v2 5/6] ASoC: jz4740: Use the generic dmaengine PCM driver Lars-Peter Clausen
2013-05-30 16:25 ` [PATCH v2 6/6] MIPS: jz4740: Remove custom DMA API Lars-Peter Clausen
2013-05-30 17:20 ` Vinod Koul
2013-05-30 18:48 ` Lars-Peter Clausen
2013-06-21 14:13 ` [PATCH 0/6] Convert JZ4740 to dmaengine Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B60D0A.7040307@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=maarten@treewalker.org \
--cc=ralf@linux-mips.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox