public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sekhar Nori <nsekhar@ti.com>
To: Philip Avinash <avinashphilip@ti.com>
Cc: <khilman@deeprootsystems.com>, <linux@arm.linux.org.uk>,
	<grant.likely@secretlab.ca>, <linus.walleij@linaro.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<davinci-linux-open-source@linux.davincidsp.com>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 02/11] gpio: davinci: coding style correction
Date: Tue, 11 Jun 2013 17:12:19 +0530	[thread overview]
Message-ID: <51B70D1B.1080208@ti.com> (raw)
In-Reply-To: <1369206634-6778-3-git-send-email-avinashphilip@ti.com>

On 5/22/2013 12:40 PM, Philip Avinash wrote:
> 1. Corrects coding and commenting styles
> 2. Variables name change to meaningful name
> 3. Remove unnecessary variable usage
> 4. Add BINTEN macro definition
> 
> Signed-off-by: Philip Avinash <avinashphilip@ti.com>

As Russell mentioned, the 80 char limit changes are churn. I looked at
the variable name renaming and that's also churn with little benefit.
The only changes that are probably worth doing are alphabetical ordering
of include files, fixes for mult-line commenting style and usage of
macro for register offset.

As I started reviewing these patches, I also started fixing some of the
comments I had and I have pushed the resulting work here:

https://git.kernel.org/cgit/linux/kernel/git/nsekhar/linux-davinci.git/log/?h=devel-gpio

It is only compile tested, but I hope this will serve as good starting
point for your next submission.

Thanks,
Sekhar

  parent reply	other threads:[~2013-06-11 11:42 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-22  7:10 [PATCH 00/11] Convert GPIO Davinci to platform driver Philip Avinash
2013-05-22  7:10 ` [PATCH 01/11] ARM: davinci: GPIO: Add platform data structure Philip Avinash
2013-05-30 18:06   ` Linus Walleij
2013-06-11 10:36   ` Sekhar Nori
2013-06-11 11:10     ` Sergei Shtylyov
2013-06-11 12:53     ` Philip, Avinash
2013-05-22  7:10 ` [PATCH 02/11] gpio: davinci: coding style correction Philip Avinash
2013-05-22 12:59   ` Sergei Shtylyov
2013-05-23  6:27     ` Philip, Avinash
2013-05-22 14:40   ` Russell King - ARM Linux
2013-05-23  6:27     ` Philip, Avinash
2013-06-11 11:42   ` Sekhar Nori [this message]
2013-05-22  7:10 ` [PATCH 03/11] gpio: davinci: Modify to platform driver Philip Avinash
2013-05-30 18:12   ` Linus Walleij
2013-06-11 11:56   ` Sekhar Nori
2013-06-11 12:55     ` Philip, Avinash
2013-06-12  7:43       ` Sekhar Nori
2013-06-12 12:10         ` Philip, Avinash
2013-06-13  6:17           ` Sekhar Nori
2013-06-13  7:32             ` Philip, Avinash
2013-06-13  8:29               ` Sekhar Nori
2013-06-13  9:18                 ` Philip, Avinash
2013-05-22  7:10 ` [PATCH 04/11] ARM: davinci: da8xx: creation of gpio platform device Philip Avinash
2013-05-30 18:14   ` Linus Walleij
2013-05-22  7:10 ` [PATCH 05/11] ARM: davinci: creation of gpio platform device for dm platforms Philip Avinash
2013-05-30 18:15   ` Linus Walleij
2013-05-22  7:10 ` [PATCH 06/11] ARM: davinci: da8xx: gpio device creation Philip Avinash
2013-05-30 18:16   ` Linus Walleij
2013-05-22  7:10 ` [PATCH 07/11] ARM: davinci: create davinci gpio device for dm platforms Philip Avinash
2013-05-30 18:16   ` Linus Walleij
2013-05-22  7:10 ` [PATCH 08/11] ARM: davinci: start using gpiolib support Philip Avinash
2013-05-30 18:19   ` Linus Walleij
2013-05-22  7:10 ` [PATCH 09/11] gpio: davinci: DT changes for driver Philip Avinash
2013-05-30 18:25   ` Linus Walleij
2013-06-10 11:45     ` Philip, Avinash
2013-05-22  7:10 ` [PATCH 10/11] ARM: davinci: da850: add GPIO DT entries Philip Avinash
2013-05-22  7:10 ` [PATCH 11/11] ARM: davinci: da850 evm: add GPIO DT data Philip Avinash
2013-05-30 18:26   ` Linus Walleij
2013-05-30 18:04 ` [PATCH 00/11] Convert GPIO Davinci to platform driver Linus Walleij
2013-06-07  8:10 ` Sekhar Nori
2013-06-10  9:02   ` Philip, Avinash
2013-06-11  4:39     ` Sekhar Nori
2013-06-11  6:49       ` Philip, Avinash
2013-06-11 11:40         ` Sekhar Nori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51B70D1B.1080208@ti.com \
    --to=nsekhar@ti.com \
    --cc=avinashphilip@ti.com \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    --cc=grant.likely@secretlab.ca \
    --cc=khilman@deeprootsystems.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox