From: Andy Lutomirski <luto@MIT.EDU>
To: vcaputo@gnugeneration.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: adopt(pid_t pid) syscall proposal [patch included]
Date: Tue, 11 Jun 2013 09:48:22 -0700 [thread overview]
Message-ID: <51B754D6.6010606@mit.edu> (raw)
In-Reply-To: <20130611012304.GI5638@shells.gnugeneration.com>
On 06/10/2013 06:23 PM, vcaputo@gnugeneration.com wrote:
> + if (!uid_eq(cred->euid, tcred->suid) &&
> + !uid_eq(cred->euid, tcred->uid) &&
> + !uid_eq(cred->uid, tcred->suid) &&
> + !uid_eq(cred->uid, tcred->uid) &&
> + !ns_capable(cred->user_ns, CAP_KILL)) {
> + ret = -EPERM;
> + goto out_unlock;
> + }
> +
That check's far too permissive.
This sounds like it will break anything that uses wait and expects its
children to not be stolen out from under it.
Also, you'll have problems with screen -x or the default tmux shareable
configuration. It sounds like this is better done in userspace.
--Andy
next prev parent reply other threads:[~2013-06-11 16:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 1:23 adopt(pid_t pid) syscall proposal [patch included] vcaputo
2013-06-11 16:48 ` Andy Lutomirski [this message]
2013-06-11 18:38 ` vcaputo
2013-06-11 18:47 ` Andrew Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B754D6.6010606@mit.edu \
--to=luto@mit.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=vcaputo@gnugeneration.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox