From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: "B, Ravi" <ravibabu@ti.com>
Cc: "ABRAHAM, KISHON VIJAY" <kishon@ti.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Balbi, Felipe" <balbi@ti.com>
Subject: Re: [PATCH v2 2/7] usb: phy: dsps: adding usbphy driver for am33xx platform
Date: Tue, 11 Jun 2013 22:52:44 +0400 [thread overview]
Message-ID: <51B771FC.1000203@cogentembedded.com> (raw)
In-Reply-To: <6C6B28D4DC342643927BEAFCE8707BF63EB02C13@DBDE04.ent.ti.com>
Hello.
On 06/11/2013 01:45 PM, B, Ravi wrote:
>>> +
>>> + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "phy_wkup");
>>> + phy->phy_wkup = ioremap(res->start, resource_size(res));
>> devm_ioremap?
> The phy_wakeup register is common across two instances of phy, devm_ioremap_resource() will fail to map for twice for same register space.
I've already told you the register can't be shared between devices
like this. BTW, you haven't replied to my request concerning your
/proc/iomem contents...
WBR, Sergei
next prev parent reply other threads:[~2013-06-11 18:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 7:17 [PATCH v2 0/7] adding dual instance and usb-phy support for am335x platform Ravi Babu
2013-06-11 7:17 ` [PATCH v2 1/7] usb: musb: dsps: enable dual instance support for am33xx platform Ravi Babu
2013-06-11 7:17 ` [PATCH v2 2/7] usb: phy: dsps: adding usbphy driver " Ravi Babu
2013-06-11 8:40 ` Kishon Vijay Abraham I
2013-06-11 9:45 ` B, Ravi
2013-06-11 18:52 ` Sergei Shtylyov [this message]
2013-06-12 7:20 ` B, Ravi
2013-06-12 7:22 ` B, Ravi
2013-06-11 7:17 ` [PATCH v2 3/7] usb: musb: dsps: remove nop_xceiv_(un)register APIs from dsps glue Ravi Babu
2013-06-11 7:17 ` [PATCH v2 4/7] usb: musb: dsps: use usb-phy driver API for phy power on/off Ravi Babu
2013-06-11 7:17 ` [PATCH v2 5/7] usb: musb: dsps: use get-usb-phy by phandle for multi instance Ravi Babu
2013-06-11 7:17 ` [PATCH v2 6/7] usb: phy: dts: Adding usbphy DT bindings for am33xx Ravi Babu
2013-06-11 7:17 ` [PATCH v2 7/7] usb: musb: dsp: remove the usb-phy control acess from platform glue Ravi Babu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B771FC.1000203@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=balbi@ti.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ravibabu@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox