From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756567Ab3FLOzx (ORCPT ); Wed, 12 Jun 2013 10:55:53 -0400 Received: from multi.imgtec.com ([194.200.65.239]:37250 "EHLO multi.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753106Ab3FLOzw (ORCPT ); Wed, 12 Jun 2013 10:55:52 -0400 Message-ID: <51B88BD0.805@imgtec.com> Date: Wed, 12 Jun 2013 15:55:12 +0100 From: James Hogan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: =?UTF-8?B?SGVpa28gU3TDvGJuZXI=?= CC: Linus Walleij , Patrice Chotard , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/2] pinctrl: add function to parse generic pinconfig properties from a dt node References: <201306102139.32444.heiko@sntech.de> <201306102140.29918.heiko@sntech.de> In-Reply-To: <201306102140.29918.heiko@sntech.de> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [192.168.154.65] X-SEF-Processed: 7_3_0_01192__2013_06_12_15_55_49 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Heiko, On 10/06/13 20:40, Heiko Stübner wrote: > pinconf_generic_parse_dt_config() takes a node as input and generates an > array of generic pinconfig values from the properties of this node. > > As I couldn't find a mechanism to count the number of properties of a node > the function uses internally an array to accept one of parameter and copies > the real present options to a smaller variable at its end. > > Signed-off-by: Heiko Stuebner > @@ -139,3 +140,83 @@ void pinconf_generic_dump_config(struct pinctrl_dev *pctldev, > } > EXPORT_SYMBOL_GPL(pinconf_generic_dump_config); > #endif > + > +#ifdef CONFIG_OF > +struct pinconf_generic_dt_params { > + const char * const property; > + enum pin_config_param param; > + u32 default_value; > +}; > + > +static struct pinconf_generic_dt_params dt_params[] = { > + { "bias-disable", PIN_CONFIG_BIAS_DISABLE, 0 }, > + { "bias-high-impedance", PIN_CONFIG_BIAS_HIGH_IMPEDANCE, 0 }, > + { "bias-bus-hold", PIN_CONFIG_BIAS_BUS_HOLD, 0 }, > + { "bias-pull-up", PIN_CONFIG_BIAS_PULL_UP, 0 }, > + { "bias-pull-down", PIN_CONFIG_BIAS_PULL_DOWN, 0 }, > + { "bias-pull-pin-default", PIN_CONFIG_BIAS_PULL_PIN_DEFAULT, 0 }, > + { "drive-push-pull", PIN_CONFIG_DRIVE_PUSH_PULL, 0 }, > + { "drive-open-drain", PIN_CONFIG_DRIVE_OPEN_DRAIN, 0 }, > + { "drive-open-source", PIN_CONFIG_DRIVE_OPEN_SOURCE, 0 }, > + { "drive-strength", PIN_CONFIG_DRIVE_STRENGTH, 0 }, > + { "input-schmitt-enable", PIN_CONFIG_INPUT_SCHMITT_ENABLE, 1 }, > + { "input-schmitt-disable", PIN_CONFIG_INPUT_SCHMITT_ENABLE, 0 }, > + { "input-schmitt", PIN_CONFIG_INPUT_SCHMITT, 0 }, > + { "input-debounce", PIN_CONFIG_INPUT_DEBOUNCE, 0 }, > + { "power-source", PIN_CONFIG_POWER_SOURCE, 0 }, > + { "slew-rate", PIN_CONFIG_SLEW_RATE, 0 }, > + { "low-power-mode", PIN_CONFIG_LOW_POWER_MODE, 0 }, > + { "output-low", PIN_CONFIG_OUTPUT, 0, }, > + { "output-high", PIN_CONFIG_OUTPUT, 1, }, shouldn't half of these default to 1 instead of 0? i.e. it's much nicer for the lone flag "bias-pull-up" to enable pull up rather than disable it (you even do this in the DT example in the bindings doc). Otherwise the patch looks good to me (though I haven't tried it yet). Cheers James