From: "H. Peter Anvin" <hpa@zytor.com>
To: mingo@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org,
keescook@chromium.org, pageexec@freemail.hu, tglx@linutronix.de,
hpa@linux.intel.com
Subject: Re: [tip:x86/urgent] x86: Fix typo in kexec register clearing
Date: Wed, 12 Jun 2013 15:22:39 -0700 [thread overview]
Message-ID: <51B8F4AF.2070801@zytor.com> (raw)
In-Reply-To: <tip-c8a22d19dd238ede87aa0ac4f7dbea8da039b9c1@git.kernel.org>
On 06/12/2013 03:21 PM, tip-bot for Kees Cook wrote:
> Commit-ID: c8a22d19dd238ede87aa0ac4f7dbea8da039b9c1
> Gitweb: http://git.kernel.org/tip/c8a22d19dd238ede87aa0ac4f7dbea8da039b9c1
> Author: Kees Cook <keescook@chromium.org>
> AuthorDate: Wed, 5 Jun 2013 11:47:18 -0700
> Committer: H. Peter Anvin <hpa@linux.intel.com>
> CommitDate: Wed, 12 Jun 2013 15:16:18 -0700
>
> x86: Fix typo in kexec register clearing
>
> Fixes a typo in register clearing code. Thanks to PaX Team for fixing
> this originally, and James Troup for pointing it out.
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> Link: http://lkml.kernel.org/r/20130605184718.GA8396@www.outflux.net
> Cc: <stable@vger.kernel.org> v2.6.30+
> Cc: PaX Team <pageexec@freemail.hu>
> Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
> ---
> arch/x86/kernel/relocate_kernel_64.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kernel/relocate_kernel_64.S b/arch/x86/kernel/relocate_kernel_64.S
> index 7a6f3b3..f2bb9c9 100644
> --- a/arch/x86/kernel/relocate_kernel_64.S
> +++ b/arch/x86/kernel/relocate_kernel_64.S
> @@ -160,7 +160,7 @@ identity_mapped:
> xorq %rbp, %rbp
> xorq %r8, %r8
> xorq %r9, %r9
> - xorq %r10, %r9
> + xorq %r10, %r10
> xorq %r11, %r11
> xorq %r12, %r12
> xorq %r13, %r13
>
As an aside: using xorq here is totally pointless; xorl would work just
fine.
-hpa
prev parent reply other threads:[~2013-06-12 22:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 18:47 [PATCH] x86: fix typo in kexec register clearing Kees Cook
2013-06-12 22:21 ` [tip:x86/urgent] x86: Fix " tip-bot for Kees Cook
2013-06-12 22:22 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B8F4AF.2070801@zytor.com \
--to=hpa@zytor.com \
--cc=hpa@linux.intel.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pageexec@freemail.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox