* [PATCH] x86: fix typo in kexec register clearing
@ 2013-06-05 18:47 Kees Cook
2013-06-12 22:21 ` [tip:x86/urgent] x86: Fix " tip-bot for Kees Cook
0 siblings, 1 reply; 3+ messages in thread
From: Kees Cook @ 2013-06-05 18:47 UTC (permalink / raw)
To: linux-kernel; +Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86, PaX Team
Fixes a typo in register clearing code. Thanks to PaX Team for fixing
this originally, and James Troup for pointing it out.
Signed-off-by: Kees Cook <keescook@chromium.org>
Cc: stable@vger.kernel.org
Cc: PaX Team <pageexec@freemail.hu>
---
arch/x86/kernel/relocate_kernel_64.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/relocate_kernel_64.S b/arch/x86/kernel/relocate_kernel_64.S
index 7a6f3b3..f2bb9c9 100644
--- a/arch/x86/kernel/relocate_kernel_64.S
+++ b/arch/x86/kernel/relocate_kernel_64.S
@@ -160,7 +160,7 @@ identity_mapped:
xorq %rbp, %rbp
xorq %r8, %r8
xorq %r9, %r9
- xorq %r10, %r9
+ xorq %r10, %r10
xorq %r11, %r11
xorq %r12, %r12
xorq %r13, %r13
--
1.7.9.5
--
Kees Cook
Chrome OS Security
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [tip:x86/urgent] x86: Fix typo in kexec register clearing
2013-06-05 18:47 [PATCH] x86: fix typo in kexec register clearing Kees Cook
@ 2013-06-12 22:21 ` tip-bot for Kees Cook
2013-06-12 22:22 ` H. Peter Anvin
0 siblings, 1 reply; 3+ messages in thread
From: tip-bot for Kees Cook @ 2013-06-12 22:21 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, keescook, pageexec, tglx, hpa
Commit-ID: c8a22d19dd238ede87aa0ac4f7dbea8da039b9c1
Gitweb: http://git.kernel.org/tip/c8a22d19dd238ede87aa0ac4f7dbea8da039b9c1
Author: Kees Cook <keescook@chromium.org>
AuthorDate: Wed, 5 Jun 2013 11:47:18 -0700
Committer: H. Peter Anvin <hpa@linux.intel.com>
CommitDate: Wed, 12 Jun 2013 15:16:18 -0700
x86: Fix typo in kexec register clearing
Fixes a typo in register clearing code. Thanks to PaX Team for fixing
this originally, and James Troup for pointing it out.
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: http://lkml.kernel.org/r/20130605184718.GA8396@www.outflux.net
Cc: <stable@vger.kernel.org> v2.6.30+
Cc: PaX Team <pageexec@freemail.hu>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
---
arch/x86/kernel/relocate_kernel_64.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/relocate_kernel_64.S b/arch/x86/kernel/relocate_kernel_64.S
index 7a6f3b3..f2bb9c9 100644
--- a/arch/x86/kernel/relocate_kernel_64.S
+++ b/arch/x86/kernel/relocate_kernel_64.S
@@ -160,7 +160,7 @@ identity_mapped:
xorq %rbp, %rbp
xorq %r8, %r8
xorq %r9, %r9
- xorq %r10, %r9
+ xorq %r10, %r10
xorq %r11, %r11
xorq %r12, %r12
xorq %r13, %r13
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [tip:x86/urgent] x86: Fix typo in kexec register clearing
2013-06-12 22:21 ` [tip:x86/urgent] x86: Fix " tip-bot for Kees Cook
@ 2013-06-12 22:22 ` H. Peter Anvin
0 siblings, 0 replies; 3+ messages in thread
From: H. Peter Anvin @ 2013-06-12 22:22 UTC (permalink / raw)
To: mingo, hpa, linux-kernel, keescook, pageexec, tglx, hpa
On 06/12/2013 03:21 PM, tip-bot for Kees Cook wrote:
> Commit-ID: c8a22d19dd238ede87aa0ac4f7dbea8da039b9c1
> Gitweb: http://git.kernel.org/tip/c8a22d19dd238ede87aa0ac4f7dbea8da039b9c1
> Author: Kees Cook <keescook@chromium.org>
> AuthorDate: Wed, 5 Jun 2013 11:47:18 -0700
> Committer: H. Peter Anvin <hpa@linux.intel.com>
> CommitDate: Wed, 12 Jun 2013 15:16:18 -0700
>
> x86: Fix typo in kexec register clearing
>
> Fixes a typo in register clearing code. Thanks to PaX Team for fixing
> this originally, and James Troup for pointing it out.
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> Link: http://lkml.kernel.org/r/20130605184718.GA8396@www.outflux.net
> Cc: <stable@vger.kernel.org> v2.6.30+
> Cc: PaX Team <pageexec@freemail.hu>
> Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
> ---
> arch/x86/kernel/relocate_kernel_64.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kernel/relocate_kernel_64.S b/arch/x86/kernel/relocate_kernel_64.S
> index 7a6f3b3..f2bb9c9 100644
> --- a/arch/x86/kernel/relocate_kernel_64.S
> +++ b/arch/x86/kernel/relocate_kernel_64.S
> @@ -160,7 +160,7 @@ identity_mapped:
> xorq %rbp, %rbp
> xorq %r8, %r8
> xorq %r9, %r9
> - xorq %r10, %r9
> + xorq %r10, %r10
> xorq %r11, %r11
> xorq %r12, %r12
> xorq %r13, %r13
>
As an aside: using xorq here is totally pointless; xorl would work just
fine.
-hpa
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-12 22:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-05 18:47 [PATCH] x86: fix typo in kexec register clearing Kees Cook
2013-06-12 22:21 ` [tip:x86/urgent] x86: Fix " tip-bot for Kees Cook
2013-06-12 22:22 ` H. Peter Anvin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox