From: Li Zefan <lizefan@huawei.com>
To: Tejun Heo <tj@kernel.org>
Cc: <containers@lists.linux-foundation.org>,
<cgroups@vger.kernel.org>, <koverstreet@google.com>,
<linux-kernel@vger.kernel.org>, <cl@linux-foundation.org>
Subject: Re: [PATCH 03/11] cgroup: bring some sanity to naming around cg_cgroup_link
Date: Thu, 13 Jun 2013 10:34:56 +0800 [thread overview]
Message-ID: <51B92FD0.8020907@huawei.com> (raw)
In-Reply-To: <1371070996-20613-4-git-send-email-tj@kernel.org>
On 2013/6/13 5:03, Tejun Heo wrote:
> cgroups and css_sets are mapped M:N and this M:N mapping is
> represented by struct cg_cgroup_link which points to forms linked
> lists on both sides. The naming around this already confusing struct
> is pretty bad.
>
>>From cgroup side, it starts off ->css_sets and runs through
> ->cgrp_link_list. From css_set side, it starts off ->cg_links and
> runs through ->cg_link_list. This is rather reversed as
> cgrp_link_list is used to iterate css_sets and cg_link_list cgroups.
> Also, this is the only place which is still using the confusing "cg"
> for css_sets. This patch cleans it up a bit.
>
> * s/cgroup->css_sets/cgroup->cset_links/
> s/css_set->cg_links/css_set->cgrp_links/
> s/cgroup_iter->cg_link/cgroup_iter->cset_link/
>
> * s/cg_cgroup_link/cgrp_cset_link/
>
> * s/cgrp_cset_link->cg/cgrp_cset_link->cset/
> s/cgrp_cset_link->cgrp_link_list/cgrp_cset_link->cset_link/
> s/cgrp_cset_link->cg_link_list/cgrp_cset_link->cgrp_link/
>
> * s/init_css_set_link/init_cgrp_cset_link/
> s/free_cg_links/free_cgrp_cset_links/
> s/allocate_cg_links/allocate_cgrp_cset_links/
>
> * s/cgl[12]/link[12]/ in compare_css_sets()
>
> * s/saved_link/tmp_link/ s/tmp/tmp_links/ and a couple similar
> adustments.
>
> * Comment and whiteline adjustments.
>
> After the changes, we have
>
> list_for_each_entry(link, &cont->cset_links, cset_link) {
> struct css_set *cset = link->cset;
>
> instead of
>
> list_for_each_entry(link, &cont->css_sets, cgrp_link_list) {
> struct css_set *cset = link->cg;
>
Those renames really make the code more readable! I have to think for a while
everytime I see those namings.
next prev parent reply other threads:[~2013-06-13 2:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-12 21:03 [PATCHSET cgroup/for-3.11] cgroup: convert cgroup_subsys_state refcnt to percpu_ref Tejun Heo
2013-06-12 21:03 ` [PATCH 01/11] cgroup: remove now unused css_depth() Tejun Heo
2013-06-12 21:03 ` [PATCH 02/11] cgroup: consistently use @cset for struct css_set variables Tejun Heo
2013-06-12 21:03 ` [PATCH 03/11] cgroup: bring some sanity to naming around cg_cgroup_link Tejun Heo
2013-06-13 2:34 ` Li Zefan [this message]
2013-06-12 21:03 ` [PATCH 04/11] cgroup: use kzalloc() and list_del_init() Tejun Heo
2013-06-13 2:36 ` Li Zefan
2013-06-13 2:38 ` Kent Overstreet
2013-06-13 2:41 ` Tejun Heo
2013-06-13 2:43 ` Kent Overstreet
2013-06-13 2:48 ` Tejun Heo
2013-06-13 2:52 ` Kent Overstreet
2013-06-13 2:56 ` Tejun Heo
2013-06-13 3:05 ` Tejun Heo
2013-06-13 3:13 ` Li Zefan
2013-06-13 2:39 ` Tejun Heo
2013-06-12 21:03 ` [PATCH 05/11] cgroup: clean up css_[try]get() and css_put() Tejun Heo
2013-06-13 2:38 ` Li Zefan
2013-06-12 21:03 ` [PATCH 06/11] cgroup: rename CGRP_REMOVED to CGRP_DEAD Tejun Heo
2013-06-12 21:03 ` [PATCH 07/11] cgroup: drop unnecessary RCU dancing from __put_css_set() Tejun Heo
2013-06-12 21:03 ` [PATCH 08/11] cgroup: remove cgroup->count and use Tejun Heo
2013-06-12 21:03 ` [PATCH 09/11] cgroup: reorder the operations in cgroup_destroy_locked() Tejun Heo
2013-06-12 21:03 ` [PATCH 10/11] cgroup: split cgroup destruction into two steps Tejun Heo
2013-06-12 21:03 ` [PATCH 11/11] cgroup: use percpu refcnt for cgroup_subsys_states Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2013-06-13 4:04 [PATCHSET v2 cgroup/for-3.11] cgroup: convert cgroup_subsys_state refcnt to percpu_ref Tejun Heo
2013-06-13 4:04 ` [PATCH 03/11] cgroup: bring some sanity to naming around cg_cgroup_link Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B92FD0.8020907@huawei.com \
--to=lizefan@huawei.com \
--cc=cgroups@vger.kernel.org \
--cc=cl@linux-foundation.org \
--cc=containers@lists.linux-foundation.org \
--cc=koverstreet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox