linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [GIT PULL] pstore/ram for 3.11
@ 2013-06-13  3:44 Rob Herring
  2013-06-14 22:18 ` Tony Luck
  0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2013-06-13  3:44 UTC (permalink / raw)
  To: Kees Cook, Anton Vorontsov, Colin Cross, Tony Luck
  Cc: linux-kernel@vger.kernel.org

Not sure who takes this, but please pull these 2 changes for pstore for
3.11. These are necessary to get pstore to work with on-chip RAM on
Calxeda highbank platform.

I dropped the write-combine change from this series. While write-combine
is technically the correct mapping needed for ARM, it doesn't solve any
problem for me.

Rob

The following changes since commit c7788792a5e7b0d5d7f96d0766b4cb6112d47d75:

  Linux 3.10-rc2 (2013-05-20 14:37:38 -0700)

are available in the git repository at:

  git://sources.calxeda.com/kernel/linux.git tags/pstore-for-3.11

for you to fetch changes up to da98a8882b3b388e9580821c8ad281c85f94d025:

  pstore/ram: avoid atomic accesses for ioremapped regions (2013-05-21
15:32:44 -0500)

----------------------------------------------------------------
2 changes for pstore ram:

- Don't use atomic ops on ioremapped RAM which is not supported on ARM
- Allow non-power of 2 sized RAM buffers

----------------------------------------------------------------
Rob Herring (2):
      pstore/ram: remove the power of buffer size limitation
      pstore/ram: avoid atomic accesses for ioremapped regions

 fs/pstore/ram.c      |  2 --
 fs/pstore/ram_core.c | 54
++++++++++++++++++++++++++++++++++++++++++++++++++--
 2 files changed, 52 insertions(+), 4 deletions(-)

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [GIT PULL] pstore/ram for 3.11
  2013-06-13  3:44 [GIT PULL] pstore/ram for 3.11 Rob Herring
@ 2013-06-14 22:18 ` Tony Luck
  2013-06-14 22:32   ` Rob Herring
  0 siblings, 1 reply; 5+ messages in thread
From: Tony Luck @ 2013-06-14 22:18 UTC (permalink / raw)
  To: Rob Herring
  Cc: Kees Cook, Anton Vorontsov, Colin Cross,
	linux-kernel@vger.kernel.org

On Wed, Jun 12, 2013 at 8:44 PM, Rob Herring <robherring2@gmail.com> wrote:
> Not sure who takes this, but please pull these 2 changes for pstore for
> 3.11. These are necessary to get pstore to work with on-chip RAM on
> Calxeda highbank platform.

Were these posted for discussion and review?  Is there anyone who should
be providing {Acked,Reviewed,Tested}-by: tags for them?  I haven't ever had
a sub-maintained tree to pull from - so I'm being double-extra cautious before
doing something with this as it all feels new and strange.

-Tony

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [GIT PULL] pstore/ram for 3.11
  2013-06-14 22:18 ` Tony Luck
@ 2013-06-14 22:32   ` Rob Herring
  2013-06-14 22:47     ` Anton Vorontsov
  0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2013-06-14 22:32 UTC (permalink / raw)
  To: Tony Luck
  Cc: Kees Cook, Anton Vorontsov, Colin Cross,
	linux-kernel@vger.kernel.org

On 06/14/2013 05:18 PM, Tony Luck wrote:
> On Wed, Jun 12, 2013 at 8:44 PM, Rob Herring <robherring2@gmail.com> wrote:
>> Not sure who takes this, but please pull these 2 changes for pstore for
>> 3.11. These are necessary to get pstore to work with on-chip RAM on
>> Calxeda highbank platform.
> 
> Were these posted for discussion and review?  Is there anyone who should
> be providing {Acked,Reviewed,Tested}-by: tags for them?  I haven't ever had
> a sub-maintained tree to pull from - so I'm being double-extra cautious before
> doing something with this as it all feels new and strange.

Yes, here:

https://lkml.org/lkml/2013/4/9/831

The main discussion was around the write-combining change which I
dropped. You can pick patches 2 and 3 off the mail list if you prefer. I
would assume they only require an ack from one of the 4 of you which
pulling the tree implicitly does.

Rob

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [GIT PULL] pstore/ram for 3.11
  2013-06-14 22:32   ` Rob Herring
@ 2013-06-14 22:47     ` Anton Vorontsov
  2013-06-14 22:57       ` Tony Luck
  0 siblings, 1 reply; 5+ messages in thread
From: Anton Vorontsov @ 2013-06-14 22:47 UTC (permalink / raw)
  To: Rob Herring
  Cc: Tony Luck, Kees Cook, Colin Cross, linux-kernel@vger.kernel.org

On Fri, Jun 14, 2013 at 05:32:16PM -0500, Rob Herring wrote:
> https://lkml.org/lkml/2013/4/9/831
> 
> The main discussion was around the write-combining change which I
> dropped. You can pick patches 2 and 3 off the mail list if you prefer. I
> would assume they only require an ack from one of the 4 of you which
> pulling the tree implicitly does.

I've just re-reviewed the discussion. I see Colin was talking about ftrace
causing infinite loops due to recursion. Once I stumbled onto this too
(but the issue itself was due to missing 'notrace' mark), and Stephen told
that recursion protection is kind of mandatory:

  http://lists.linaro.org/pipermail/linaro-kernel/2012-August/002084.html

I belive that the protection is actually there nowadays, and that is why
Rob does not see the problem with his patch.

So, I guess the patches are good, at least they fix real issues for Rob.
:)

	Acked-by: Anton Vorontsov <anton@enomsg.org>

(Or I can pick this via linux-pstore.git tree, I'll let Tony decide.)

Thanks!

Anton

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [GIT PULL] pstore/ram for 3.11
  2013-06-14 22:47     ` Anton Vorontsov
@ 2013-06-14 22:57       ` Tony Luck
  0 siblings, 0 replies; 5+ messages in thread
From: Tony Luck @ 2013-06-14 22:57 UTC (permalink / raw)
  To: Anton Vorontsov
  Cc: Rob Herring, Kees Cook, Colin Cross, linux-kernel@vger.kernel.org

On Fri, Jun 14, 2013 at 3:47 PM, Anton Vorontsov <anton@enomsg.org> wrote:
>
>         Acked-by: Anton Vorontsov <anton@enomsg.org>
>
> (Or I can pick this via linux-pstore.git tree, I'll let Tony decide.)

Added that Acked-by: and applied to my tree.

Thanks

-Tony

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2013-06-14 22:57 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-13  3:44 [GIT PULL] pstore/ram for 3.11 Rob Herring
2013-06-14 22:18 ` Tony Luck
2013-06-14 22:32   ` Rob Herring
2013-06-14 22:47     ` Anton Vorontsov
2013-06-14 22:57       ` Tony Luck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).