* [PATCH] uprobes: fix return value in error handling path
@ 2013-06-13 6:21 zhangwei(Jovi)
2013-06-17 16:56 ` Steven Rostedt
0 siblings, 1 reply; 3+ messages in thread
From: zhangwei(Jovi) @ 2013-06-13 6:21 UTC (permalink / raw)
To: Steven Rostedt, Frederic Weisbecker, srikar,
linux-kernel@vger.kernel.org
When I inject incorrect argument into uprobe_events,
[root@jovi tracing]# echo 'p:myprobe /bin/bash' > uprobe_events
[root@jovi tracing]#
it doesn't return any error value in there, this patch fix it.
Signed-off-by: zhangwei(Jovi) <jovi.zhangwei@huawei.com>
---
kernel/trace/trace_uprobe.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
index 32494fb0..d5d0cd3 100644
--- a/kernel/trace/trace_uprobe.c
+++ b/kernel/trace/trace_uprobe.c
@@ -283,8 +283,10 @@ static int create_trace_uprobe(int argc, char **argv)
return -EINVAL;
}
arg = strchr(argv[1], ':');
- if (!arg)
+ if (!arg) {
+ ret = -EINVAL;
goto fail_address_parse;
+ }
*arg++ = '\0';
filename = argv[1];
--
1.7.9.7
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] uprobes: fix return value in error handling path
2013-06-13 6:21 [PATCH] uprobes: fix return value in error handling path zhangwei(Jovi)
@ 2013-06-17 16:56 ` Steven Rostedt
2013-07-02 23:06 ` Steven Rostedt
0 siblings, 1 reply; 3+ messages in thread
From: Steven Rostedt @ 2013-06-17 16:56 UTC (permalink / raw)
To: zhangwei(Jovi); +Cc: Frederic Weisbecker, srikar, linux-kernel@vger.kernel.org
Srikar,
Can you give an Ack (or nack) for this?
Thanks,
-- Steve
On Thu, 2013-06-13 at 14:21 +0800, zhangwei(Jovi) wrote:
> When I inject incorrect argument into uprobe_events,
>
> [root@jovi tracing]# echo 'p:myprobe /bin/bash' > uprobe_events
> [root@jovi tracing]#
>
> it doesn't return any error value in there, this patch fix it.
>
> Signed-off-by: zhangwei(Jovi) <jovi.zhangwei@huawei.com>
> ---
> kernel/trace/trace_uprobe.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> index 32494fb0..d5d0cd3 100644
> --- a/kernel/trace/trace_uprobe.c
> +++ b/kernel/trace/trace_uprobe.c
> @@ -283,8 +283,10 @@ static int create_trace_uprobe(int argc, char **argv)
> return -EINVAL;
> }
> arg = strchr(argv[1], ':');
> - if (!arg)
> + if (!arg) {
> + ret = -EINVAL;
> goto fail_address_parse;
> + }
>
> *arg++ = '\0';
> filename = argv[1];
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] uprobes: fix return value in error handling path
2013-06-17 16:56 ` Steven Rostedt
@ 2013-07-02 23:06 ` Steven Rostedt
0 siblings, 0 replies; 3+ messages in thread
From: Steven Rostedt @ 2013-07-02 23:06 UTC (permalink / raw)
To: zhangwei(Jovi); +Cc: Frederic Weisbecker, srikar, linux-kernel@vger.kernel.org
On Mon, 2013-06-17 at 12:56 -0400, Steven Rostedt wrote:
> Srikar,
>
> Can you give an Ack (or nack) for this?
>
This looks rather obvious, I'll apply it and also tag it for stable.
-- Steve
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-07-02 23:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-13 6:21 [PATCH] uprobes: fix return value in error handling path zhangwei(Jovi)
2013-06-17 16:56 ` Steven Rostedt
2013-07-02 23:06 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).