* [PATCH] tracing/kprobes: remove unnecessary checking of, trace_probe_is_enabled
@ 2013-06-14 2:10 zhangwei(Jovi)
2013-06-14 3:02 ` Masami Hiramatsu
0 siblings, 1 reply; 3+ messages in thread
From: zhangwei(Jovi) @ 2013-06-14 2:10 UTC (permalink / raw)
To: Steven Rostedt, Frederic Weisbecker
Cc: Ingo Molnar, Masami Hiramatsu, Srikar Dronamraju, Oleg Nesterov,
linux-kernel@vger.kernel.org
Since tp->flags assignment was moved into function enable_trace_probe,
so there have no need to use trace_probe_is_enabled to check flags
in same function.
Remove the unnecessary checking.
Signed-off-by: zhangwei(Jovi) <jovi.zhangwei@huawei.com>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
---
kernel/trace/trace_kprobe.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
index 9f46e98..f237417 100644
--- a/kernel/trace/trace_kprobe.c
+++ b/kernel/trace/trace_kprobe.c
@@ -240,8 +240,7 @@ enable_trace_probe(struct trace_probe *tp, struct ftrace_event_file *file)
} else
tp->flags |= TP_FLAG_PROFILE;
- if (trace_probe_is_enabled(tp) && trace_probe_is_registered(tp) &&
- !trace_probe_has_gone(tp)) {
+ if (trace_probe_is_registered(tp) && !trace_probe_has_gone(tp)) {
if (trace_probe_is_return(tp))
ret = enable_kretprobe(&tp->rp);
else
--
1.7.9.7
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] tracing/kprobes: remove unnecessary checking of, trace_probe_is_enabled
2013-06-14 2:10 [PATCH] tracing/kprobes: remove unnecessary checking of, trace_probe_is_enabled zhangwei(Jovi)
@ 2013-06-14 3:02 ` Masami Hiramatsu
2013-06-17 16:53 ` Steven Rostedt
0 siblings, 1 reply; 3+ messages in thread
From: Masami Hiramatsu @ 2013-06-14 3:02 UTC (permalink / raw)
To: zhangwei(Jovi)
Cc: Steven Rostedt, Frederic Weisbecker, Ingo Molnar,
Srikar Dronamraju, Oleg Nesterov, linux-kernel@vger.kernel.org,
yrl.pp-manager.tt@hitachi.com
(2013/06/14 11:10), zhangwei(Jovi) wrote:
> Since tp->flags assignment was moved into function enable_trace_probe,
> so there have no need to use trace_probe_is_enabled to check flags
> in same function.
Indeed :)
>
> Remove the unnecessary checking.
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
>
> Signed-off-by: zhangwei(Jovi) <jovi.zhangwei@huawei.com>
> Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Oleg Nesterov <oleg@redhat.com>
> Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> ---
> kernel/trace/trace_kprobe.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
> index 9f46e98..f237417 100644
> --- a/kernel/trace/trace_kprobe.c
> +++ b/kernel/trace/trace_kprobe.c
> @@ -240,8 +240,7 @@ enable_trace_probe(struct trace_probe *tp, struct ftrace_event_file *file)
> } else
> tp->flags |= TP_FLAG_PROFILE;
>
> - if (trace_probe_is_enabled(tp) && trace_probe_is_registered(tp) &&
> - !trace_probe_has_gone(tp)) {
> + if (trace_probe_is_registered(tp) && !trace_probe_has_gone(tp)) {
> if (trace_probe_is_return(tp))
> ret = enable_kretprobe(&tp->rp);
> else
>
--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] tracing/kprobes: remove unnecessary checking of, trace_probe_is_enabled
2013-06-14 3:02 ` Masami Hiramatsu
@ 2013-06-17 16:53 ` Steven Rostedt
0 siblings, 0 replies; 3+ messages in thread
From: Steven Rostedt @ 2013-06-17 16:53 UTC (permalink / raw)
To: Masami Hiramatsu
Cc: zhangwei(Jovi), Frederic Weisbecker, Ingo Molnar,
Srikar Dronamraju, Oleg Nesterov, linux-kernel@vger.kernel.org,
yrl.pp-manager.tt@hitachi.com
On Fri, 2013-06-14 at 12:02 +0900, Masami Hiramatsu wrote:
> (2013/06/14 11:10), zhangwei(Jovi) wrote:
> > Since tp->flags assignment was moved into function enable_trace_probe,
> > so there have no need to use trace_probe_is_enabled to check flags
> > in same function.
>
> Indeed :)
>
> >
> > Remove the unnecessary checking.
>
>
> Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
>
Thanks, I added this to my 3.11 queue.
-- Steve
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-17 16:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-14 2:10 [PATCH] tracing/kprobes: remove unnecessary checking of, trace_probe_is_enabled zhangwei(Jovi)
2013-06-14 3:02 ` Masami Hiramatsu
2013-06-17 16:53 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox