From: Tony Prisk <linux@prisktech.co.nz>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: vt8500-wm8505-linux-kernel@googlegroups.com,
linux-arm-kernel@lists.infradead.org, linux@arm.linux.org.uk,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] i2c: vt8500: Add support for I2C bus on Wondermedia SoCs
Date: Sun, 16 Jun 2013 09:58:53 +1200 [thread overview]
Message-ID: <51BCE39D.4030505@prisktech.co.nz> (raw)
In-Reply-To: <20130615111817.GA2938@katana>
On 15/06/13 23:18, Wolfram Sang wrote:
> On Sat, Jun 15, 2013 at 09:52:16AM +1200, Tony Prisk wrote:
>> This patch adds support for the I2C bus controllers found on Wondermedia
>> 8xxx-series SoCs. Only master-mode is supported.
>>
>> Signed-off-by: Tony Prisk <linux@prisktech.co.nz>
>> ---
> ...
>
>> +/* REG_TR */
>> +#define SCL_TIMEOUT(x) (((x) & 0xFF) << 16)
> I assume this should be << 8 since all regs are 16 bit wide.
>
> Fixed it locally and ready to apply. Please confirm or send a proper
> fix. Rest looks fine.
>
> Thanks for the submission!
>
It should be << 8. Please apply your locally corrected version.
Regards
Tony Prisk
next prev parent reply other threads:[~2013-06-15 21:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-14 21:52 [PATCH v3] i2c: vt8500: Add support for I2C bus on Wondermedia SoCs Tony Prisk
2013-06-15 11:18 ` Wolfram Sang
2013-06-15 21:58 ` Tony Prisk [this message]
2013-06-17 7:12 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51BCE39D.4030505@prisktech.co.nz \
--to=linux@prisktech.co.nz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=vt8500-wm8505-linux-kernel@googlegroups.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox