From: Alex Shi <alex.shi@intel.com>
To: Alex Shi <alex.shi@intel.com>,
mingo@redhat.com, peterz@infradead.org, pjt@google.com
Cc: tglx@linutronix.de, akpm@linux-foundation.org, bp@alien8.de,
namhyung@kernel.org, efault@gmx.de, morten.rasmussen@arm.com,
vincent.guittot@linaro.org, preeti@linux.vnet.ibm.com,
viresh.kumar@linaro.org, linux-kernel@vger.kernel.org,
mgorman@suse.de, riel@redhat.com, wangyun@linux.vnet.ibm.com,
Jason Low <jason.low2@hp.com>
Subject: Re: [RFC patch 0/4] change 64 bit variables to long type
Date: Mon, 17 Jun 2013 09:01:55 +0800 [thread overview]
Message-ID: <51BE6003.6010507@intel.com> (raw)
In-Reply-To: <51BB26B5.5000102@intel.com>
On 06/14/2013 10:20 PM, Alex Shi wrote:
> On 06/07/2013 03:29 PM, Alex Shi wrote:
>> There are some 64 bits variables in cfs_rq/tg etc. That ask expensive
>> operations in 32 bit machine. But in fact, long type is enough for them.
>>
>> So do this change lead more efficient code and without data lose.
>>
>
> some variable like cfs_rq->runnable_load_avg, there is no much changes
> in patch 1/4, since in most of place it was treated as a 'unsigned
> long', not u64.
>
The patchset change some u64 load avg variables to 'unsigned long' type,
because the related load variable is 'unsigned long' too.
Peter,
It looks quite straight. So if Paul is too busy to look into this,
Believe you can do decide independent. :)
>> Regards
>> Alex
>>
>
>
--
Thanks
Alex
prev parent reply other threads:[~2013-06-17 1:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 7:29 [RFC patch 0/4] change 64 bit variables to long type Alex Shi
2013-06-07 7:29 ` [RFC patch 1/4] sched: change cfs_rq load avg to unsigned long Alex Shi
2013-06-07 9:07 ` Vincent Guittot
2013-06-08 2:18 ` Alex Shi
2013-06-17 9:49 ` Paul Turner
2013-06-17 9:59 ` Alex Shi
2013-06-17 9:54 ` Vincent Guittot
2013-06-17 9:58 ` Alex Shi
2013-06-18 4:56 ` Alex Shi
2013-06-07 7:29 ` [RFC patch 2/4] sched/tg: use 'unsigned long' for load variable in task group Alex Shi
2013-06-17 12:25 ` Paul Turner
2013-06-17 15:26 ` Alex Shi
2013-06-07 7:29 ` [RFC patch 3/4] sched/cfs_rq: change atomic64_t removed_load to atomic_long_t Alex Shi
2013-06-17 10:19 ` Paul Turner
2013-06-07 7:29 ` [RFC patch 4/4] sched/tg: remove tg.load_weight Alex Shi
2013-06-17 12:22 ` Paul Turner
2013-06-10 2:20 ` [RFC patch 0/4] change 64 bit variables to long type Alex Shi
2013-06-11 6:13 ` Alex Shi
2013-06-14 14:20 ` Alex Shi
2013-06-17 1:01 ` Alex Shi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51BE6003.6010507@intel.com \
--to=alex.shi@intel.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=efault@gmx.de \
--cc=jason.low2@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=preeti@linux.vnet.ibm.com \
--cc=riel@redhat.com \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=wangyun@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox