public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: majianpeng <majianpeng@gmail.com>
To: sage@inktank.com
Cc: ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] ceph: remove sb_start/end_write in ceph_aio_write.
Date: Mon, 17 Jun 2013 22:19:19 +0800	[thread overview]
Message-ID: <51BF1AE7.8040300@gmail.com> (raw)

Either in vfs_write or io_submit,it call file_start/end_write.
The different between file_start/end_write and sb_start/end_write is
file_ only handle regular file.But i think in ceph_aio_write,it only
for regular file.

Signed-off-by: Jianpeng Ma<majianpeng@gmail.com>
---
  fs/ceph/file.c | 2 --
  1 file changed, 2 deletions(-)

diff --git a/fs/ceph/file.c b/fs/ceph/file.c
index 656e169..7c69f4f 100644
--- a/fs/ceph/file.c
+++ b/fs/ceph/file.c
@@ -716,7 +716,6 @@ static ssize_t ceph_aio_write(struct kiocb *iocb, const struct iovec *iov,
  	if (ceph_snap(inode) != CEPH_NOSNAP)
  		return -EROFS;
  
-	sb_start_write(inode->i_sb);
  	mutex_lock(&inode->i_mutex);
  	hold_mutex = true;
  
@@ -809,7 +808,6 @@ retry_snap:
  out:
  	if (hold_mutex)
  		mutex_unlock(&inode->i_mutex);
-	sb_end_write(inode->i_sb);
  	current->backing_dev_info = NULL;
  
  	return written ? written : err;
-- 1.8.3.rc1.44.gb387c77


             reply	other threads:[~2013-06-17 14:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-17 14:19 majianpeng [this message]
2013-06-23  8:01 ` [PATCH] ceph: remove sb_start/end_write in ceph_aio_write Yan, Zheng
2013-06-23 16:49   ` Sage Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51BF1AE7.8040300@gmail.com \
    --to=majianpeng@gmail.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sage@inktank.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox