From: Stephen Warren <swarren@wwwdotorg.org>
To: Tuomas Tynkkynen <ttynkkynen@nvidia.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 1/2] mfd: tps65910: Fix crash in i2c_driver .probe
Date: Mon, 17 Jun 2013 12:16:33 -0600 [thread overview]
Message-ID: <51BF5281.2030105@wwwdotorg.org> (raw)
In-Reply-To: <1371491257-23791-2-git-send-email-ttynkkynen@nvidia.com>
On 06/17/2013 11:47 AM, Tuomas Tynkkynen wrote:
> Commit "i2c: core: make it possible to match a pure device tree driver"
> changed semantics of the i2c probing for device tree devices.
> Device tree probed devices now get a NULL i2c_device_id pointer.
> This caused kernel panics due to NULL dereference.
Tested-by: Stephen Warren <swarren@nvidia.com>
(although I imagine I'd need to retest if there was a v2 to address my
previous comments)
next prev parent reply other threads:[~2013-06-17 18:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 17:47 [PATCH 0/2] Fix kernel panics with certain I2C tps6* chips Tuomas Tynkkynen
2013-06-17 17:47 ` [PATCH 1/2] mfd: tps65910: Fix crash in i2c_driver .probe Tuomas Tynkkynen
2013-06-17 18:07 ` Stephen Warren
2013-06-18 9:35 ` Tuomas Tynkkynen
2013-06-17 18:16 ` Stephen Warren [this message]
2013-06-18 9:16 ` Samuel Ortiz
2013-06-17 17:47 ` [PATCH 2/2] regulator: tps62360: " Tuomas Tynkkynen
2013-06-17 18:16 ` Stephen Warren
2013-06-18 7:52 ` [PATCH 0/2] Fix kernel panics with certain I2C tps6* chips Linus Walleij
2013-06-18 15:58 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51BF5281.2030105@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linus.walleij@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=ttynkkynen@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox