From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754077Ab3FRD3g (ORCPT ); Mon, 17 Jun 2013 23:29:36 -0400 Received: from intranet.asianux.com ([58.214.24.6]:61045 "EHLO intranet.asianux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752922Ab3FRD3f (ORCPT ); Mon, 17 Jun 2013 23:29:35 -0400 X-Spam-Score: -100.8 Message-ID: <51BFD3EC.7010201@asianux.com> Date: Tue, 18 Jun 2013 11:28:44 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Thomas Gleixner CC: "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] kernel: timer: looping issue, need reset variable 'found' References: <51B4A408.4050909@asianux.com> <51B93EFC.9060008@asianux.com> In-Reply-To: <51B93EFC.9060008@asianux.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sorry again for replying late, and now I can focus on this patch, I will see the related details again. Thanks. On 06/13/2013 11:39 AM, Chen Gang wrote: > > Sorry for replying late during these days, firstly. > > > On 06/10/2013 10:12 PM, Thomas Gleixner wrote: >> On Sun, 9 Jun 2013, Chen Gang wrote: >> >>>> >>>> According to __internal_add_timer(), in _next_timer_interrupt(), when >>>> 'tv1.vec' find one, but need 'cascade bucket(s)', we still need find >>>> each slot of 'tv*.vec'. >> No, we do not. We only need to scan the first cascade array after the >> enqueued timer. If there is nothing in tv2 which might come before the >> found timer, then any timer in tv3 will be later than the one we found >> in the primary wheel. >> > > OK, thanks, I should read details to confirm it (at least now, I still > not quite be sure about it). > > >>>> So need reset variable 'found', so can fully scan ''do {...} while()'' >>>> for 'tv*.vec'. >> And thereby lose the information, that we already found a timer in the >> scan of the primary array. > > Hmm..., I should read details. > > > And excuse me, I also have to do another things during these days, so > maybe reply late. > > > Thanks. > -- Chen Gang Asianux Corporation