[GIT PULL] extcon for 3.11

[GIT PULL] extcon for 3.11

[Chanwoo Choi]

Hi Greg,

First of all, I'm so sorry about previous wrong pull-request.
I will be careful and not to make same mistakes

This is extcon-next pull request for 3.11
Please pull extcon with following updates.

I combined the patch of small fix and new drivers becasue
3.10-rc version is large.

Best Regards,
Chanwoo Choi

The following changes since commit 317ddd256b9c24b0d78fa8018f80f1e495481a10:

  Linux 3.10-rc5 (2013-06-08 17:41:04 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/extcon.git tags/extcon-next-for-3.11

for you to fetch changes up to f7ae906806279e5b57bfd302b945e1bcdddce95b:

  extcon: Add an API to get extcon device from dt node (2013-06-14 18:36:34 +0900)

----------------------------------------------------------------
Update extcon for 3.11

This patchset modify small fix of extcon core driver and add new extcon
driver for Palmas device which is USB tranceiver device. Also, support
OF helper API to get the name of extcon device(producer driver) on extcon
consumer driver.

Detailed description for patchset:
1. Modify extcon-class driver
- Change permission 'state' sysfs entry(rw->r)
- Use EXPORT_SYMBOL_GPL for exported functions
- Fix bug null pointer when call extcon_unregister_interest

2. Modify Kconfig of extcon
- Change the extcon config type to bool from module. If extcon
is built as module and then extcon consumer driver uses API of,
extcon, compiler happen "undefined reference to" build error.

3. Add new extcon driver for Palmas device and OF helper API
- Add new extcon drvier for Palmas which is USB tranceiver device
- Add OF(Open Firmware) Helper API which is of_extcon_get_extcon_dev()
  This helper API get the extcon device name on extcon consumer device.

----------------------------------------------------------------
Chanwoo Choi (1):
      extcon: Change permission 'state' sysfs entry (rw -> r)

Graeme Gregory (1):
      extcon: Palmas Extcon Driver

Jonghwa Lee (1):
      extcon: class: Add NULL pointer checking for removing notifier block.

Kishon Vijay Abraham I (3):
      extcon: Kconfig: Make extcon config type as bool
      extcon: add EXPORT_SYMBOL_GPL for exported functions
      extcon: Add an API to get extcon device from dt node

 .../devicetree/bindings/extcon/extcon-twl.txt      |  15 ++
 drivers/extcon/Kconfig                             |   9 +-
 drivers/extcon/Makefile                            |   3 +
 drivers/extcon/extcon-class.c                      |  30 +--
 drivers/extcon/extcon-palmas.c                     | 246 +++++++++++++++++++++
 drivers/extcon/of_extcon.c                         |  64 ++++++
 include/linux/extcon/of_extcon.h                   |  32 +++
 include/linux/mfd/palmas.h                         |  26 ++-
 8 files changed, 388 insertions(+), 37 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/extcon/extcon-twl.txt
 create mode 100644 drivers/extcon/extcon-palmas.c
 create mode 100644 drivers/extcon/of_extcon.c
 create mode 100644 include/linux/extcon/of_extcon.h

Re: [GIT PULL] extcon for 3.11

[Greg KH]

On Fri, Jun 14, 2013 at 09:39:13PM +0900, Chanwoo Choi wrote:
> Hi Greg,
> 
> First of all, I'm so sorry about previous wrong pull-request.
> I will be careful and not to make same mistakes
> 
> This is extcon-next pull request for 3.11
> Please pull extcon with following updates.
> 
> I combined the patch of small fix and new drivers becasue
> 3.10-rc version is large.
> 
> Best Regards,
> Chanwoo Choi
> 
> The following changes since commit 317ddd256b9c24b0d78fa8018f80f1e495481a10:
> 
>   Linux 3.10-rc5 (2013-06-08 17:41:04 -0700)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/extcon.git tags/extcon-next-for-3.11
> 
> for you to fetch changes up to f7ae906806279e5b57bfd302b945e1bcdddce95b:
> 
>   extcon: Add an API to get extcon device from dt node (2013-06-14 18:36:34 +0900)
> 
> ----------------------------------------------------------------
> Update extcon for 3.11
> 
> This patchset modify small fix of extcon core driver and add new extcon
> driver for Palmas device which is USB tranceiver device. Also, support
> OF helper API to get the name of extcon device(producer driver) on extcon
> consumer driver.
> 
> Detailed description for patchset:
> 1. Modify extcon-class driver
> - Change permission 'state' sysfs entry(rw->r)
> - Use EXPORT_SYMBOL_GPL for exported functions
> - Fix bug null pointer when call extcon_unregister_interest
> 
> 2. Modify Kconfig of extcon
> - Change the extcon config type to bool from module. If extcon
> is built as module and then extcon consumer driver uses API of,
> extcon, compiler happen "undefined reference to" build error.
> 
> 3. Add new extcon driver for Palmas device and OF helper API
> - Add new extcon drvier for Palmas which is USB tranceiver device
> - Add OF(Open Firmware) Helper API which is of_extcon_get_extcon_dev()
>   This helper API get the extcon device name on extcon consumer device.
> 
> ----------------------------------------------------------------
> Chanwoo Choi (1):
>       extcon: Change permission 'state' sysfs entry (rw -> r)
> 
> Graeme Gregory (1):
>       extcon: Palmas Extcon Driver
> 
> Jonghwa Lee (1):
>       extcon: class: Add NULL pointer checking for removing notifier block.
> 
> Kishon Vijay Abraham I (3):
>       extcon: Kconfig: Make extcon config type as bool

Why is this change made?  Why can't I have the extcon core as a module?
What changed to prevent this?

Because of this, I'm going to pick and choose from this pull, feel free
to resend what I don't take, as emails, so we can discuss them that
way...

thanks,

greg k-h

Re: [GIT PULL] extcon for 3.11

[Greg KH]

On Mon, Jun 17, 2013 at 04:01:19PM -0700, Greg KH wrote:
> On Fri, Jun 14, 2013 at 09:39:13PM +0900, Chanwoo Choi wrote:
> > Hi Greg,
> > 
> > First of all, I'm so sorry about previous wrong pull-request.
> > I will be careful and not to make same mistakes
> > 
> > This is extcon-next pull request for 3.11
> > Please pull extcon with following updates.
> > 
> > I combined the patch of small fix and new drivers becasue
> > 3.10-rc version is large.
> > 
> > Best Regards,
> > Chanwoo Choi
> > 
> > The following changes since commit 317ddd256b9c24b0d78fa8018f80f1e495481a10:
> > 
> >   Linux 3.10-rc5 (2013-06-08 17:41:04 -0700)
> > 
> > are available in the git repository at:
> > 
> >   git://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/extcon.git tags/extcon-next-for-3.11
> > 
> > for you to fetch changes up to f7ae906806279e5b57bfd302b945e1bcdddce95b:
> > 
> >   extcon: Add an API to get extcon device from dt node (2013-06-14 18:36:34 +0900)
> > 
> > ----------------------------------------------------------------
> > Update extcon for 3.11
> > 
> > This patchset modify small fix of extcon core driver and add new extcon
> > driver for Palmas device which is USB tranceiver device. Also, support
> > OF helper API to get the name of extcon device(producer driver) on extcon
> > consumer driver.
> > 
> > Detailed description for patchset:
> > 1. Modify extcon-class driver
> > - Change permission 'state' sysfs entry(rw->r)
> > - Use EXPORT_SYMBOL_GPL for exported functions
> > - Fix bug null pointer when call extcon_unregister_interest
> > 
> > 2. Modify Kconfig of extcon
> > - Change the extcon config type to bool from module. If extcon
> > is built as module and then extcon consumer driver uses API of,
> > extcon, compiler happen "undefined reference to" build error.
> > 
> > 3. Add new extcon driver for Palmas device and OF helper API
> > - Add new extcon drvier for Palmas which is USB tranceiver device
> > - Add OF(Open Firmware) Helper API which is of_extcon_get_extcon_dev()
> >   This helper API get the extcon device name on extcon consumer device.
> > 
> > ----------------------------------------------------------------
> > Chanwoo Choi (1):
> >       extcon: Change permission 'state' sysfs entry (rw -> r)
> > 
> > Graeme Gregory (1):
> >       extcon: Palmas Extcon Driver
> > 
> > Jonghwa Lee (1):
> >       extcon: class: Add NULL pointer checking for removing notifier block.
> > 
> > Kishon Vijay Abraham I (3):
> >       extcon: Kconfig: Make extcon config type as bool
> 
> Why is this change made?  Why can't I have the extcon core as a module?
> What changed to prevent this?

And hint, I know why you did this, and it's not the correct way, please
fix it up properly...

thanks,

greg k-h

Re: [GIT PULL] extcon for 3.11

[Chanwoo Choi]

On 06/18/2013 08:03 AM, Greg KH wrote:
> On Mon, Jun 17, 2013 at 04:01:19PM -0700, Greg KH wrote:
>> On Fri, Jun 14, 2013 at 09:39:13PM +0900, Chanwoo Choi wrote:
>>> Hi Greg,
>>>
>>> First of all, I'm so sorry about previous wrong pull-request.
>>> I will be careful and not to make same mistakes
>>>
>>> This is extcon-next pull request for 3.11
>>> Please pull extcon with following updates.
>>>
>>> I combined the patch of small fix and new drivers becasue
>>> 3.10-rc version is large.
>>>
>>> Best Regards,
>>> Chanwoo Choi
>>>
>>> The following changes since commit 317ddd256b9c24b0d78fa8018f80f1e495481a10:
>>>
>>>   Linux 3.10-rc5 (2013-06-08 17:41:04 -0700)
>>>
>>> are available in the git repository at:
>>>
>>>   git://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/extcon.git tags/extcon-next-for-3.11
>>>
>>> for you to fetch changes up to f7ae906806279e5b57bfd302b945e1bcdddce95b:
>>>
>>>   extcon: Add an API to get extcon device from dt node (2013-06-14 18:36:34 +0900)
>>>
>>> ----------------------------------------------------------------
>>> Update extcon for 3.11
>>>
>>> This patchset modify small fix of extcon core driver and add new extcon
>>> driver for Palmas device which is USB tranceiver device. Also, support
>>> OF helper API to get the name of extcon device(producer driver) on extcon
>>> consumer driver.
>>>
>>> Detailed description for patchset:
>>> 1. Modify extcon-class driver
>>> - Change permission 'state' sysfs entry(rw->r)
>>> - Use EXPORT_SYMBOL_GPL for exported functions
>>> - Fix bug null pointer when call extcon_unregister_interest
>>>
>>> 2. Modify Kconfig of extcon
>>> - Change the extcon config type to bool from module. If extcon
>>> is built as module and then extcon consumer driver uses API of,
>>> extcon, compiler happen "undefined reference to" build error.
>>>
>>> 3. Add new extcon driver for Palmas device and OF helper API
>>> - Add new extcon drvier for Palmas which is USB tranceiver device
>>> - Add OF(Open Firmware) Helper API which is of_extcon_get_extcon_dev()
>>>   This helper API get the extcon device name on extcon consumer device.
>>>
>>> ----------------------------------------------------------------
>>> Chanwoo Choi (1):
>>>       extcon: Change permission 'state' sysfs entry (rw -> r)
>>>
>>> Graeme Gregory (1):
>>>       extcon: Palmas Extcon Driver
>>>
>>> Jonghwa Lee (1):
>>>       extcon: class: Add NULL pointer checking for removing notifier block.
>>>
>>> Kishon Vijay Abraham I (3):
>>>       extcon: Kconfig: Make extcon config type as bool
>>
>> Why is this change made?  Why can't I have the extcon core as a module?
>> What changed to prevent this?
> 
> And hint, I know why you did this, and it's not the correct way, please
> fix it up properly...

OK, I fix this issue by using the following way:
- The extcon consumer driver must have the dependency of CONFIG_EXTCON
on consumer driver's Kconfig. If extcon core is built as module,
all of the extcon consumer driver will be built as moduel too.

Thanks for your comment.

Best Regards,
Chanwoo Choi