From: Sekhar Nori <nsekhar@ti.com>
To: Prabhakar Lad <prabhakar.csengg@gmail.com>
Cc: Russell King <linux@arm.linux.org.uk>,
Mark Brown <broonie@linaro.org>, Chris Ball <cjb@laptop.org>,
LAK <linux-arm-kernel@lists.infradead.org>,
DLOS <davinci-linux-open-source@linux.davincidsp.com>,
LKML <linux-kernel@vger.kernel.org>,
"Fernandes, Joel A" <joelagnel@ti.com>
Subject: Re: [PATCH v2] ARM: edma: Convert to devm_* api
Date: Tue, 18 Jun 2013 14:05:15 +0530 [thread overview]
Message-ID: <51C01BC3.4060100@ti.com> (raw)
In-Reply-To: <1371481078-18058-1-git-send-email-prabhakar.csengg@gmail.com>
On 6/17/2013 8:27 PM, Prabhakar Lad wrote:
> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
>
> Use devm_ioremap_resource instead of reques_mem_region()/ioremap(),
> devm_request_irq() instead of request_irq() and kzalloc() calls to
> devm_kzalloc().
>
> This ensures more consistent error values and simplifies error paths.
>
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Nice clean-up. The patch did not build since <linux/err.h> was not
included. I fixed it locally and applied to v3.11/soc-2 branch of my tree.
Thanks,
Sekhar
next prev parent reply other threads:[~2013-06-18 8:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 14:57 [PATCH v2] ARM: edma: Convert to devm_* api Prabhakar Lad
2013-06-18 8:35 ` Sekhar Nori [this message]
2013-06-18 8:45 ` Prabhakar Lad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C01BC3.4060100@ti.com \
--to=nsekhar@ti.com \
--cc=broonie@linaro.org \
--cc=cjb@laptop.org \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=joelagnel@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=prabhakar.csengg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox