From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756827Ab3FSOpO (ORCPT ); Wed, 19 Jun 2013 10:45:14 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:33832 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756640Ab3FSOpM (ORCPT ); Wed, 19 Jun 2013 10:45:12 -0400 Message-ID: <51C1C3E6.8090000@ti.com> Date: Wed, 19 Jun 2013 10:44:54 -0400 From: Santosh Shilimkar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Viresh Kumar CC: , , , , , , , , , , , Subject: Re: [PATCH 08/13] cpufreq: omap: call CPUFREQ_POSTCHANGE notfier in error cases References: <957838f1065ccc20b0252e0a6d37b61f6b173970.1371630975.git.viresh.kumar@linaro.org> In-Reply-To: <957838f1065ccc20b0252e0a6d37b61f6b173970.1371630975.git.viresh.kumar@linaro.org> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 19 June 2013 04:53 AM, Viresh Kumar wrote: > PRECHANGE and POSTCHANGE notifiers must be called in groups, i.e either both > should be called or both shouldn't be. > > In case we have started PRECHANGE notifier and found an error, we must call > POSTCHANGE notifier with freqs.new = freqs.old to guarantee that sequence of > calling notifiers is complete. > > Omap driver was taking care of it well, but wasn't restoring freqs.new to > freqs.old in some cases. I wasn't required to add code for it as moving > PRECHANGE notifier down was a better option, so that we call it just before > starting frequency transition. > > Cca: Santosh Shilimkar > Signed-off-by: Viresh Kumar > --- Looks safe to me. Acked-by: Santosh Shilimkar