From: Sekhar Nori <nsekhar@ti.com>
To: Philip Avinash <avinashphilip@ti.com>
Cc: <khilman@deeprootsystems.com>, <linux@arm.linux.org.uk>,
<grant.likely@secretlab.ca>, <linus.walleij@linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<davinci-linux-open-source@linux.davincidsp.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 6/7] ARM: davinci: dmxxx: gpio device creation
Date: Thu, 20 Jun 2013 14:25:44 +0530 [thread overview]
Message-ID: <51C2C390.7090301@ti.com> (raw)
In-Reply-To: <1371202532-14628-7-git-send-email-avinashphilip@ti.com>
On 6/14/2013 3:05 PM, Philip Avinash wrote:
> Create davinci gpio device and remove gpio references in
> davinci_soc_info structure for dmxxx platforms. Also add Memory and IRQ
> resources for GPIO platform device.
>
> Signed-off-by: Philip Avinash <avinashphilip@ti.com>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
> ---
> Changes since v1:
> - Add commit message
>
> arch/arm/mach-davinci/board-dm355-evm.c | 27 ++++++++++++++++++++++++++
> arch/arm/mach-davinci/board-dm355-leopard.c | 1 +
> arch/arm/mach-davinci/board-dm365-evm.c | 28 +++++++++++++++++++++++++++
> arch/arm/mach-davinci/board-dm644x-evm.c | 26 +++++++++++++++++++++++++
> arch/arm/mach-davinci/board-dm646x-evm.c | 27 ++++++++++++++++++++++++++
> arch/arm/mach-davinci/board-neuros-osd2.c | 1 +
> arch/arm/mach-davinci/dm355.c | 4 ----
> arch/arm/mach-davinci/dm365.c | 5 -----
> arch/arm/mach-davinci/dm644x.c | 4 ----
> arch/arm/mach-davinci/dm646x.c | 4 ----
> arch/arm/mach-davinci/include/mach/common.h | 2 ++
> 11 files changed, 112 insertions(+), 17 deletions(-)
>
> diff --git a/arch/arm/mach-davinci/board-dm355-evm.c b/arch/arm/mach-davinci/board-dm355-evm.c
> index c2a0a67..05e6e86 100644
> --- a/arch/arm/mach-davinci/board-dm355-evm.c
> +++ b/arch/arm/mach-davinci/board-dm355-evm.c
> @@ -28,9 +28,11 @@
>
> #include <linux/platform_data/i2c-davinci.h>
> #include <mach/serial.h>
> +#include <mach/common.h>
> #include <linux/platform_data/mtd-davinci.h>
> #include <linux/platform_data/mmc-davinci.h>
> #include <linux/platform_data/usb-davinci.h>
> +#include <linux/platform_data/gpio-davinci.h>
>
> #include "davinci.h"
>
> @@ -376,9 +378,34 @@ static struct spi_board_info dm355_evm_spi_info[] __initconst = {
> },
> };
>
> +static struct resource dm355_gpio_resources[] = {
> + { /* registers */
> + .start = DAVINCI_GPIO_BASE,
> + .end = DAVINCI_GPIO_BASE + SZ_4K - 1,
> + .flags = IORESOURCE_MEM,
> + },
> + { /* interrupt */
> + .start = IRQ_DM355_GPIOBNK0,
> + .end = IRQ_DM355_GPIOBNK6,
> + .flags = IORESOURCE_IRQ,
> + },
> +};
Don't add these resource in board files. Granted we are not going to add
more board files, but that does not mean we add soc specific data into
board files. You need to move this into the respective SoC files.
Thanks,
Sekhar
next prev parent reply other threads:[~2013-06-20 8:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-14 9:35 [PATCH v2 0/7] Convert GPIO Davinci to platform driver Philip Avinash
2013-06-14 9:35 ` [PATCH v2 1/7] gpio: davinci: coding style correction Philip Avinash
2013-06-19 10:52 ` Sekhar Nori
2013-06-14 9:35 ` [PATCH v2 2/7] gpio: davinci: move to platform device Philip Avinash
2013-06-19 11:23 ` Sekhar Nori
2013-06-14 9:35 ` [PATCH v2 3/7] ARM: davinci: da8xx: creation of gpio " Philip Avinash
2013-06-19 11:51 ` Sekhar Nori
2013-06-14 9:35 ` [PATCH v2 4/7] ARM: davinci: creation of gpio platform device for dmxxx platforms Philip Avinash
2013-06-20 6:18 ` Sekhar Nori
2013-06-14 9:35 ` [PATCH v2 5/7] ARM: davinci: da8xx: gpio device creation Philip Avinash
2013-06-20 8:40 ` Sekhar Nori
2013-06-20 9:07 ` Sekhar Nori
2013-06-14 9:35 ` [PATCH v2 6/7] ARM: davinci: dmxxx: " Philip Avinash
2013-06-20 8:55 ` Sekhar Nori [this message]
2013-06-14 9:35 ` [PATCH v2 7/7] ARM: davinci: Start using gpiolib API inplace of inline functions Philip Avinash
2013-06-19 19:05 ` Linus Walleij
2013-06-20 9:19 ` Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C2C390.7090301@ti.com \
--to=nsekhar@ti.com \
--cc=avinashphilip@ti.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=grant.likely@secretlab.ca \
--cc=khilman@deeprootsystems.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).