Re: [for-next][PATCH 08/12] tracing: Add binary & filter for events

["Arend van Spriel" <arend@broadcom.com>]

On 06/20/13 20:38, Steven Rostedt wrote:
> On Thu, 2013-06-20 at 14:34 -0400, Steven Rostedt wrote:
>> On Thu, 2013-06-20 at 20:28 +0200, Arend van Spriel wrote:
>>
>>> Reading the whole text with your remark in mind, I guess it does
>>> indicate there are no guarantees depending on the kernel and the list of
>>> operators are what trace-cmd supports. I overlooked/ignored the text
>>> seeing the operators.
>>
>> Exactly, which means that if you over looked the text, so has others.
>> The text
>> should be changed to make it more comprehensible.
>>
>
> Would this change have helped you catch this?

Always difficult to say in retrospect, but it certainly is more clear.

Regards,
Arend

> diff --git a/Documentation/trace-cmd-record.1.txt b/Documentation/trace-cmd-record.1.txt
> index b95e1b4..9ef1e2a 100644
> --- a/Documentation/trace-cmd-record.1.txt
> +++ b/Documentation/trace-cmd-record.1.txt
> @@ -79,10 +79,12 @@ OPTIONS
>       let you use C notation to check if an event should be processed or not.
>
>   ----------------------------------------
> -    ==,>=,<=,>,<,&, |,&&  and ||
> +    ==,>=,<=,>,<,&, ~,&&  and ||
>   ----------------------------------------
>
> -    The above are usually safe to use to compare fields.
> +    Note, not all of the above operators may work with all kernels.
> +    The filter is passed directly to the kernel and is dependent on the
> +    kernel supporting the operators.
>
>   *-v*::
>       This will cause all events specified after it on the command line to not
>
> -- Steve
>
>