[PATCH] gpio-langwell: remove Withney point support

[PATCH] gpio-langwell: remove Withney point support

[Andy Shevchenko]

It seems there is no user of the wp_gpio driver in the kernel. Let's remove it.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
 drivers/gpio/gpio-langwell.c | 69 +-------------------------------------------
 1 file changed, 1 insertion(+), 68 deletions(-)

diff --git a/drivers/gpio/gpio-langwell.c b/drivers/gpio/gpio-langwell.c
index 2db6ef7..bfa1af1 100644
--- a/drivers/gpio/gpio-langwell.c
+++ b/drivers/gpio/gpio-langwell.c
@@ -20,7 +20,6 @@
 /* Supports:
  * Moorestown platform Langwell chip.
  * Medfield platform Penwell chip.
- * Whitney point.
  */
 
 #include <linux/module.h>
@@ -390,75 +389,9 @@ static struct pci_driver lnw_gpio_driver = {
 	},
 };
 
-
-static int wp_gpio_probe(struct platform_device *pdev)
-{
-	struct lnw_gpio *lnw;
-	struct gpio_chip *gc;
-	struct resource *rc;
-	int retval;
-
-	lnw = devm_kzalloc(&pdev->dev, sizeof(struct lnw_gpio), GFP_KERNEL);
-	if (!lnw) {
-		dev_err(&pdev->dev, "can't allocate chip data\n");
-		return -ENOMEM;
-	}
-
-	rc = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	lnw->reg_base = devm_ioremap_resource(&pdev->dev, rc);
-	if (IS_ERR(lnw->reg_base))
-		return PTR_ERR(lnw->reg_base);
-
-	spin_lock_init(&lnw->lock);
-	gc = &lnw->chip;
-	gc->label = dev_name(&pdev->dev);
-	gc->owner = THIS_MODULE;
-	gc->direction_input = lnw_gpio_direction_input;
-	gc->direction_output = lnw_gpio_direction_output;
-	gc->get = lnw_gpio_get;
-	gc->set = lnw_gpio_set;
-	gc->to_irq = NULL;
-	gc->base = 0;
-	gc->ngpio = 64;
-	gc->can_sleep = 0;
-	retval = gpiochip_add(gc);
-	if (retval) {
-		dev_err(&pdev->dev, "gpiochip_add error %d\n", retval);
-		return retval;
-	}
-	platform_set_drvdata(pdev, lnw);
-	return 0;
-}
-
-static int wp_gpio_remove(struct platform_device *pdev)
-{
-	struct lnw_gpio *lnw = platform_get_drvdata(pdev);
-	int err;
-	err = gpiochip_remove(&lnw->chip);
-	if (err)
-		dev_err(&pdev->dev, "failed to remove gpio_chip.\n");
-	return 0;
-}
-
-static struct platform_driver wp_gpio_driver = {
-	.probe		= wp_gpio_probe,
-	.remove		= wp_gpio_remove,
-	.driver		= {
-		.name	= "wp_gpio",
-		.owner	= THIS_MODULE,
-	},
-};
-
 static int __init lnw_gpio_init(void)
 {
-	int ret;
-	ret =  pci_register_driver(&lnw_gpio_driver);
-	if (ret < 0)
-		return ret;
-	ret = platform_driver_register(&wp_gpio_driver);
-	if (ret < 0)
-		pci_unregister_driver(&lnw_gpio_driver);
-	return ret;
+	return pci_register_driver(&lnw_gpio_driver);
 }
 
 device_initcall(lnw_gpio_init);
-- 
1.8.3.1

Re: [PATCH] gpio-langwell: remove Withney point support

[Linus Walleij]

On Tue, Jun 18, 2013 at 8:43 AM, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:

> It seems there is no user of the wp_gpio driver in the kernel. Let's remove it.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

OK patch applied.

Please give some context though, Wikipedia says:

Whitney Point is the codename of a PCH in the Oak Trail platform
chipset for Atom Lincroft microprocessors.
This has the following variations:
82SM35 (PCH SM35)

Does this mean that platform is not coming back to support Linux
ever again like it was a stepping stone or something?

Yours,
Linus Walleij

Re: [PATCH] gpio-langwell: remove Withney point support

[Andy Shevchenko]

On Wed, Jun 19, 2013 at 10:23 PM, Linus Walleij
<linus.walleij@linaro.org> wrote:

> Please give some context though, Wikipedia says:
>
> Whitney Point is the codename of a PCH in the Oak Trail platform
> chipset for Atom Lincroft microprocessors.
> This has the following variations:
> 82SM35 (PCH SM35)

> Does this mean that platform is not coming back to support Linux
> ever again

I think it's very unluckily.
May be David could shed a light...

--
With Best Regards,
Andy Shevchenko

Re: [PATCH] gpio-langwell: remove Withney point support

[Linus Walleij]

On Wed, Jun 19, 2013 at 11:02 PM, Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Wed, Jun 19, 2013 at 10:23 PM, Linus Walleij
> <linus.walleij@linaro.org> wrote:
>
>> Please give some context though, Wikipedia says:
>>
>> Whitney Point is the codename of a PCH in the Oak Trail platform
>> chipset for Atom Lincroft microprocessors.
>> This has the following variations:
>> 82SM35 (PCH SM35)
>
>> Does this mean that platform is not coming back to support Linux
>> ever again
>
> I think it's very unluckily.
> May be David could shed a light...

Is that some kind of NACK? I will pull this patch out if it is
possible that support is useful for the near future.

Yours,
Linus Walleij

Re: [PATCH] gpio-langwell: remove Withney point support

[Andy Shevchenko]

On Thu, Jun 20, 2013 at 9:46 AM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Wed, Jun 19, 2013 at 11:02 PM, Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
>> On Wed, Jun 19, 2013 at 10:23 PM, Linus Walleij
>> <linus.walleij@linaro.org> wrote:
>>
>>> Please give some context though, Wikipedia says:
>>>
>>> Whitney Point is the codename of a PCH in the Oak Trail platform
>>> chipset for Atom Lincroft microprocessors.
>>> This has the following variations:
>>> 82SM35 (PCH SM35)
>>
>>> Does this mean that platform is not coming back to support Linux
>>> ever again
>>
>> I think it's very unluckily.
>> May be David could shed a light...
>
> Is that some kind of NACK?

No, the opposite.
I meant it's very unluckily that we will have any Oak Trail user in future.

--
With Best Regards,
Andy Shevchenko

Re: [PATCH] gpio-langwell: remove Withney point support

[Mika Westerberg]

On Thu, Jun 20, 2013 at 10:09:37AM +0300, Andy Shevchenko wrote:
> On Thu, Jun 20, 2013 at 9:46 AM, Linus Walleij <linus.walleij@linaro.org> wrote:
> > On Wed, Jun 19, 2013 at 11:02 PM, Andy Shevchenko
> > <andy.shevchenko@gmail.com> wrote:
> >> On Wed, Jun 19, 2013 at 10:23 PM, Linus Walleij
> >> <linus.walleij@linaro.org> wrote:
> >>
> >>> Please give some context though, Wikipedia says:
> >>>
> >>> Whitney Point is the codename of a PCH in the Oak Trail platform
> >>> chipset for Atom Lincroft microprocessors.
> >>> This has the following variations:
> >>> 82SM35 (PCH SM35)
> >>
> >>> Does this mean that platform is not coming back to support Linux
> >>> ever again
> >>
> >> I think it's very unluckily.
> >> May be David could shed a light...
> >
> > Is that some kind of NACK?
> 
> No, the opposite.
> I meant it's very unluckily that we will have any Oak Trail user in future.

You mean *unlikely*, right?

AFAICT there are no real Oak Trail products outside Intel. It was
superseded by Medfield.

Re: [PATCH] gpio-langwell: remove Withney point support

[Linus Walleij]

On Thu, Jun 20, 2013 at 10:02 AM, Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
> On Thu, Jun 20, 2013 at 10:09:37AM +0300, Andy Shevchenko wrote:
>> On Thu, Jun 20, 2013 at 9:46 AM, Linus Walleij <linus.walleij@linaro.org> wrote:
>> > On Wed, Jun 19, 2013 at 11:02 PM, Andy Shevchenko
>> > <andy.shevchenko@gmail.com> wrote:
>> >> On Wed, Jun 19, 2013 at 10:23 PM, Linus Walleij
>> >> <linus.walleij@linaro.org> wrote:
>> >>
>> >>> Please give some context though, Wikipedia says:
>> >>>
>> >>> Whitney Point is the codename of a PCH in the Oak Trail platform
>> >>> chipset for Atom Lincroft microprocessors.
>> >>> This has the following variations:
>> >>> 82SM35 (PCH SM35)
>> >>
>> >>> Does this mean that platform is not coming back to support Linux
>> >>> ever again
>> >>
>> >> I think it's very unluckily.
>> >> May be David could shed a light...
>> >
>> > Is that some kind of NACK?
>>
>> No, the opposite.
>> I meant it's very unluckily that we will have any Oak Trail user in future.
>
> You mean *unlikely*, right?
>
> AFAICT there are no real Oak Trail products outside Intel. It was
> superseded by Medfield.

Only lab boards then? OK I will keep this patch around.

Yours,
Linus Walleij

Re: [PATCH] gpio-langwell: remove Withney point support

[David Cohen]

Hi Andy,

On 06/17/2013 11:43 PM, Andy Shevchenko wrote:
> It seems there is no user of the wp_gpio driver in the kernel. Let's remove it.

I never liked this wp code there too.

>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Acked-by: David Cohen <david.a.cohen@intel.com>