From: Michal Simek <monstr@monstr.eu>
To: Pavel Machek <pavel@ucw.cz>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Hans J. Koch" <hjk@hansjkoch.de>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] uio: Add two platform uio drivers to one
Date: Fri, 21 Jun 2013 11:06:17 +0200 [thread overview]
Message-ID: <51C41789.8070903@monstr.eu> (raw)
In-Reply-To: <20130620231346.GB1589@amd.pavel.ucw.cz>
[-- Attachment #1: Type: text/plain, Size: 1346 bytes --]
On 06/21/2013 01:13 AM, Pavel Machek wrote:
> Hi!
>
>>>>> can you please comment this?
>>>>
>>>> I'll let Hans handle this, as he's the UIO maintainer now.
>>>
>>> Looks good to me.
>>>
>>> Anyway, Hans disappeared, so Greg takes patches, again. Take a look,
>>> it seems I already did some changes you wanted, they are in char-misc
>>> tree.
>>
>> Can you send me link to that repo?
>
> I googled a mirror...
>
> https://kernel.googlesource.com/pub/scm/linux/kernel/git/gregkh/char-misc/+/char-misc-next/drivers/uio/uio_pdrv_genirq.c
Ok. I see.
Yeah it can be done in that way too.
I can rebase my patches on the top of that because they are still valid.
1/2 is not there and it is nice way how to simplify the code.
The purpose of 2/2 was to remove that uio_pdrv.c which is not needed
when uio_pdrv_genirq.c also support no IRQ case.
Will be good if you can look at my patches and test them.
Also we should also simplify the driver by using devres groups,
devm_kzalloc, etc.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
next prev parent reply other threads:[~2013-06-21 9:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 14:01 [RFC PATCH 1/2] uio: Use Use of_match_ptr() macro in uio_pdrv_genirq.c Michal Simek
2013-05-23 14:01 ` [RFC PATCH 2/2] uio: Add two platform uio drivers to one Michal Simek
2013-05-29 11:28 ` Michal Simek
2013-06-03 12:34 ` Michal Simek
2013-06-03 21:05 ` Greg Kroah-Hartman
2013-06-12 5:43 ` Michal Simek
2013-06-20 16:01 ` Pavel Machek
2013-06-20 16:20 ` [PATCH] MAINTAINERS: Remove Hans J. Koch entries Joe Perches
2013-06-20 16:30 ` [lm-sensors] " Guenter Roeck
2013-06-20 17:09 ` Joe Perches
2013-06-21 2:50 ` Hans J. Koch
2013-06-21 3:08 ` Joe Perches
2013-06-21 7:47 ` [lm-sensors] " Jean Delvare
2013-06-21 9:15 ` Michal Simek
2013-06-20 17:11 ` [RFC PATCH 2/2] uio: Add two platform uio drivers to one Michal Simek
2013-06-20 23:13 ` Pavel Machek
2013-06-21 9:06 ` Michal Simek [this message]
2013-06-10 8:59 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C41789.8070903@monstr.eu \
--to=monstr@monstr.eu \
--cc=gregkh@linuxfoundation.org \
--cc=hjk@hansjkoch.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).